* [PATCH] iw_cxgb4: fix for 64-bit integer division
@ 2014-07-17 17:01 Hariprasad Shenai
[not found] ` <1405616463-23156-1-git-send-email-hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Hariprasad Shenai @ 2014-07-17 17:01 UTC (permalink / raw)
To: netdev-u79uwXL29TY76Z2rM5mHXA, linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q, roland-BHEL68pLQRGGvPXPguhicg,
swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW,
leedom-ut6Up61K2wZBDgjK7y7TUQ, nirranjan-ut6Up61K2wZBDgjK7y7TUQ,
kumaras-ut6Up61K2wZBDgjK7y7TUQ, anish-ut6Up61K2wZBDgjK7y7TUQ,
Hariprasad Shenai
Fixed error introduced in commit id 7730b4c (" cxgb4/iw_cxgb4: work request
logging feature") while compiling on 32 bit architecture reported by kbuild.
Signed-off-by: Hariprasad Shenai <hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
---
drivers/infiniband/hw/cxgb4/device.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
index df1f1b5..bb0de61 100644
--- a/drivers/infiniband/hw/cxgb4/device.c
+++ b/drivers/infiniband/hw/cxgb4/device.c
@@ -33,6 +33,7 @@
#include <linux/moduleparam.h>
#include <linux/debugfs.h>
#include <linux/vmalloc.h>
+#include <linux/math64.h>
#include <rdma/ib_verbs.h>
@@ -150,7 +151,7 @@ static int wr_log_show(struct seq_file *seq, void *v)
int prev_ts_set = 0;
int idx, end;
-#define ts2ns(ts) ((ts) * dev->rdev.lldi.cclk_ps / 1000)
+#define ts2ns(ts) div64_ul((ts) * dev->rdev.lldi.cclk_ps , 1000)
idx = atomic_read(&dev->rdev.wr_log_idx) &
(dev->rdev.wr_log_size - 1);
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1405616463-23156-1-git-send-email-hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH] iw_cxgb4: fix for 64-bit integer division [not found] ` <1405616463-23156-1-git-send-email-hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org> @ 2014-07-17 18:44 ` Sergei Shtylyov [not found] ` <53C8199A.5040704-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Sergei Shtylyov @ 2014-07-17 18:44 UTC (permalink / raw) To: Hariprasad Shenai, netdev-u79uwXL29TY76Z2rM5mHXA, linux-rdma-u79uwXL29TY76Z2rM5mHXA Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q, roland-BHEL68pLQRGGvPXPguhicg, swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW, leedom-ut6Up61K2wZBDgjK7y7TUQ, nirranjan-ut6Up61K2wZBDgjK7y7TUQ, kumaras-ut6Up61K2wZBDgjK7y7TUQ, anish-ut6Up61K2wZBDgjK7y7TUQ Hello. On 07/17/2014 09:01 PM, Hariprasad Shenai wrote: > Fixed error introduced in commit id 7730b4c (" cxgb4/iw_cxgb4: work request > logging feature") while compiling on 32 bit architecture reported by kbuild. > Signed-off-by: Hariprasad Shenai <hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org> > --- > drivers/infiniband/hw/cxgb4/device.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c > index df1f1b5..bb0de61 100644 > --- a/drivers/infiniband/hw/cxgb4/device.c > +++ b/drivers/infiniband/hw/cxgb4/device.c [...] > @@ -150,7 +151,7 @@ static int wr_log_show(struct seq_file *seq, void *v) > int prev_ts_set = 0; > int idx, end; > > -#define ts2ns(ts) ((ts) * dev->rdev.lldi.cclk_ps / 1000) > +#define ts2ns(ts) div64_ul((ts) * dev->rdev.lldi.cclk_ps , 1000) Don't need space before comma. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <53C8199A.5040704-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>]
* Re: [PATCH] iw_cxgb4: fix for 64-bit integer division [not found] ` <53C8199A.5040704-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> @ 2014-07-17 23:52 ` David Miller 0 siblings, 0 replies; 3+ messages in thread From: David Miller @ 2014-07-17 23:52 UTC (permalink / raw) To: sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8 Cc: hariprasad-ut6Up61K2wZBDgjK7y7TUQ, netdev-u79uwXL29TY76Z2rM5mHXA, linux-rdma-u79uwXL29TY76Z2rM5mHXA, roland-BHEL68pLQRGGvPXPguhicg, swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW, leedom-ut6Up61K2wZBDgjK7y7TUQ, nirranjan-ut6Up61K2wZBDgjK7y7TUQ, kumaras-ut6Up61K2wZBDgjK7y7TUQ, anish-ut6Up61K2wZBDgjK7y7TUQ From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> Date: Thu, 17 Jul 2014 22:44:42 +0400 > Hello. > > On 07/17/2014 09:01 PM, Hariprasad Shenai wrote: > >> Fixed error introduced in commit id 7730b4c (" cxgb4/iw_cxgb4: work >> request >> logging feature") while compiling on 32 bit architecture reported by >> kbuild. > >> Signed-off-by: Hariprasad Shenai <hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org> >> --- >> drivers/infiniband/hw/cxgb4/device.c | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) > >> diff --git a/drivers/infiniband/hw/cxgb4/device.c >> b/drivers/infiniband/hw/cxgb4/device.c >> index df1f1b5..bb0de61 100644 >> --- a/drivers/infiniband/hw/cxgb4/device.c >> +++ b/drivers/infiniband/hw/cxgb4/device.c > [...] >> @@ -150,7 +151,7 @@ static int wr_log_show(struct seq_file *seq, void >> *v) >> int prev_ts_set = 0; >> int idx, end; >> >> -#define ts2ns(ts) ((ts) * dev->rdev.lldi.cclk_ps / 1000) >> +#define ts2ns(ts) div64_ul((ts) * dev->rdev.lldi.cclk_ps , 1000) > > Don't need space before comma. I killed the space when applying this patch, thanks everyone. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-17 23:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-17 17:01 [PATCH] iw_cxgb4: fix for 64-bit integer division Hariprasad Shenai
[not found] ` <1405616463-23156-1-git-send-email-hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2014-07-17 18:44 ` Sergei Shtylyov
[not found] ` <53C8199A.5040704-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-07-17 23:52 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).