Re: [PATCH v3 net-next 2/2] net: print net_device reg_state in netdev_* unless it's registered

[Veaceslav Falico <vfalico@gmail.com>]

On Thu, Jul 17, 2014 at 12:21:39PM -0700, Joe Perches wrote:
>On Thu, 2014-07-17 at 19:46 +0200, Veaceslav Falico wrote:
>[]
>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>[]
>> @@ -3444,7 +3459,8 @@ do {								\
>>   * file/line information and a backtrace.
>>   */
>>  #define netdev_WARN(dev, format, args...)			\
>> -	WARN(1, "netdevice: %s\n" format, netdev_name(dev), ##args)
>> +	WARN(1, "netdevice: %s%s\n" format, netdev_name(dev),	\
>> +	     netdev_reg_state(dev), ##args)
>
>trivia:
>
>My preference for style here is to have the format
>and args on one line when it fits and separate
>the format and args lines when they don't.
>
>	WARN(1, "netdevice: %s%s\n" format,
>	     netdev_name(dev), netdev_reg_state(dev), ##args)
>
>Unrelated:  maybe it'd be better to change the '\n' to ": "

Good points, but I guess they're minor. If I'll send v4 I'll include them.

>
>> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
>[]
>> -		res = printk(KERN_DEBUG "%s: %pV", netdev_name(dev), &vaf);
>> +		res = printk(KERN_DEBUG "%s%s: %pV", netdev_name(dev),
>> +			     netdev_reg_state(dev), &vaf);
>
>etc...
>
>