netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: karoly.kemeny@gmail.com
Cc: jmorris@namei.org, netdev@vger.kernel.org
Subject: Re: [PATCH] clean up sparse cast warning in do_ip_getsockopt
Date: Sun, 20 Jul 2014 22:22:46 -0700 (PDT)	[thread overview]
Message-ID: <20140720.222246.722922848026554870.davem@davemloft.net> (raw)
In-Reply-To: <20140720113017.GA8878@gmail.com>

From: Karoly Kemeny <karoly.kemeny@gmail.com>
Date: Sun, 20 Jul 2014 13:30:17 +0200

> There is a sparse warning because of the implicit pointer cast in
> do_ip_getsockopt.
> 
> Signed-off-by: Karoly Kemeny <karoly.kemeny@gmail.com>

Please format your subject line correctly, it should be of the form:

	[PATCH] ${SUBSYSTEM}: Description.

Your's is missing the subsystem prefix, which in this case should
be "ipv4: "

> -		msg.msg_control = optval;
> +		msg.msg_control = (__force void*) optval;

Please put a space between "void" and "*" in the cast.

  reply	other threads:[~2014-07-21  5:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-20 11:30 [PATCH] clean up sparse cast warning in do_ip_getsockopt Karoly Kemeny
2014-07-21  5:22 ` David Miller [this message]
2014-07-21  8:54   ` David Laight
2014-07-21 21:31     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140720.222246.722922848026554870.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jmorris@namei.org \
    --cc=karoly.kemeny@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).