[PATCH] clean up sparse cast warning in do_ip_getsockopt

[PATCH] clean up sparse cast warning in do_ip_getsockopt

[Karoly Kemeny]

There is a sparse warning because of the implicit pointer cast in
do_ip_getsockopt.

Signed-off-by: Karoly Kemeny <karoly.kemeny@gmail.com>
---
 net/ipv4/ip_sockglue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c
index 64741b9..3e4af06 100644
--- a/net/ipv4/ip_sockglue.c
+++ b/net/ipv4/ip_sockglue.c
@@ -1319,7 +1319,7 @@ static int do_ip_getsockopt(struct sock *sk, int level, int optname,
 		if (sk->sk_type != SOCK_STREAM)
 			return -ENOPROTOOPT;
 
-		msg.msg_control = optval;
+		msg.msg_control = (__force void*) optval;
 		msg.msg_controllen = len;
 		msg.msg_flags = flags;
 
-- 
1.9.1

Re: [PATCH] clean up sparse cast warning in do_ip_getsockopt

[David Miller]

From: Karoly Kemeny <karoly.kemeny@gmail.com>
Date: Sun, 20 Jul 2014 13:30:17 +0200

> There is a sparse warning because of the implicit pointer cast in
> do_ip_getsockopt.
> 
> Signed-off-by: Karoly Kemeny <karoly.kemeny@gmail.com>

Please format your subject line correctly, it should be of the form:

	[PATCH] ${SUBSYSTEM}: Description.

Your's is missing the subsystem prefix, which in this case should
be "ipv4: "

> -		msg.msg_control = optval;
> +		msg.msg_control = (__force void*) optval;

Please put a space between "void" and "*" in the cast.

RE: [PATCH] clean up sparse cast warning in do_ip_getsockopt

[David Laight]

From: David Miller
> From: Karoly Kemeny <karoly.kemeny@gmail.com>
> Date: Sun, 20 Jul 2014 13:30:17 +0200
> 
> > There is a sparse warning because of the implicit pointer cast in
> > do_ip_getsockopt.
> >
> > Signed-off-by: Karoly Kemeny <karoly.kemeny@gmail.com>
> 
> Please format your subject line correctly, it should be of the form:
> 
> 	[PATCH] ${SUBSYSTEM}: Description.
> 
> Your's is missing the subsystem prefix, which in this case should
> be "ipv4: "
> 
> > -		msg.msg_control = optval;
> > +		msg.msg_control = (__force void*) optval;
> 
> Please put a space between "void" and "*" in the cast.

And remove the one after the ')' ?

	David

Re: [PATCH] clean up sparse cast warning in do_ip_getsockopt

[David Miller]

From: David Laight <David.Laight@ACULAB.COM>
Date: Mon, 21 Jul 2014 08:54:02 +0000

> From: David Miller
>> From: Karoly Kemeny <karoly.kemeny@gmail.com>
>> Date: Sun, 20 Jul 2014 13:30:17 +0200
>> 
>> > There is a sparse warning because of the implicit pointer cast in
>> > do_ip_getsockopt.
>> >
>> > Signed-off-by: Karoly Kemeny <karoly.kemeny@gmail.com>
>> 
>> Please format your subject line correctly, it should be of the form:
>> 
>> 	[PATCH] ${SUBSYSTEM}: Description.
>> 
>> Your's is missing the subsystem prefix, which in this case should
>> be "ipv4: "
>> 
>> > -		msg.msg_control = optval;
>> > +		msg.msg_control = (__force void*) optval;
>> 
>> Please put a space between "void" and "*" in the cast.
> 
> And remove the one after the ')' ?

Not necessarily, I don't like when the closing parens and the variable
"touch".