* [PATCH -next] net: mvpp2: Fix error return code in mvpp2_probe()
@ 2014-07-20 14:02 weiyj_lk
2014-07-21 5:27 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: weiyj_lk @ 2014-07-20 14:02 UTC (permalink / raw)
To: Grant Likely, Rob Herring, David S. Miller, Ezequiel Garcia,
Marcin Wojtas
Cc: Wei Yongjun, netdev
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return -ENODEV from the no ports enabled error handling
case instead of 0.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/ethernet/marvell/mvpp2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c
index f4de2a9..1a9f848 100644
--- a/drivers/net/ethernet/marvell/mvpp2.c
+++ b/drivers/net/ethernet/marvell/mvpp2.c
@@ -6308,6 +6308,7 @@ static int mvpp2_probe(struct platform_device *pdev)
port_count = of_get_available_child_count(dn);
if (port_count == 0) {
dev_err(&pdev->dev, "no ports enabled\n");
+ err = -ENODEV;
goto err_gop_clk;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: mvpp2: Fix error return code in mvpp2_probe()
2014-07-20 14:02 [PATCH -next] net: mvpp2: Fix error return code in mvpp2_probe() weiyj_lk
@ 2014-07-21 5:27 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-07-21 5:27 UTC (permalink / raw)
To: weiyj_lk; +Cc: grant.likely, robh+dt, ezequiel.garcia, mw, yongjun_wei, netdev
From: weiyj_lk@163.com
Date: Sun, 20 Jul 2014 22:02:43 +0800
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return -ENODEV from the no ports enabled error handling
> case instead of 0.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-21 5:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-20 14:02 [PATCH -next] net: mvpp2: Fix error return code in mvpp2_probe() weiyj_lk
2014-07-21 5:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).