From: Florian Westphal <fw@strlen.de>
To: David Miller <davem@davemloft.net>
Cc: fw@strlen.de, netdev@vger.kernel.org
Subject: Re: [PATCH -next] tun: stop tx queue when limit is hit
Date: Mon, 21 Jul 2014 08:54:20 +0200 [thread overview]
Message-ID: <20140721065419.GB21375@breakpoint.cc> (raw)
In-Reply-To: <20140720.223313.1589952322700027038.davem@davemloft.net>
David Miller <davem@davemloft.net> wrote:
> From: Florian Westphal <fw@strlen.de>
> Date: Sun, 20 Jul 2014 20:51:25 +0200
>
> > Currently tun just frees the skb and returns NETDEV_TX_OK
> > when queue length exceeds txqlen.
> >
> > This causes severe packetloss and unneeded resource
> > consumption on host when sending to vm connected via tun.
> >
> > Instead, lets stop the transmit queue and start it once
> > packets are consumed from the queue. This allows the network
> > stack to control applications that send data via tun device.
>
> I strongly suspect the current behavior is intentional, see
> commit:
>
> commit 5d097109257c03a71845729f8db6b5770c4bbedc
> Author: Michael S. Tsirkin <mst@redhat.com>
> Date: Mon Dec 3 10:07:14 2012 +0000
>
> tun: only queue packets on device
Looks like you're right :-/
Alright, please ignore my patch.
That being said, the current behaviour isn't ideal either.
It took me quite some time to realize that packetloss
was on the sender side inside tun driver and not on the receiver
vm. Not stopping the queue was a bit ... unexpected.
next prev parent reply other threads:[~2014-07-21 6:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 18:51 [PATCH -next] tun: stop tx queue when limit is hit Florian Westphal
2014-07-21 5:33 ` David Miller
2014-07-21 6:54 ` Florian Westphal [this message]
2014-07-21 8:31 ` Florian Westphal
2014-07-21 8:56 ` Eric Dumazet
2014-07-21 9:19 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721065419.GB21375@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).