From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Jason Cooper <jason@lakedaemon.net>,
Gregory Clement <gregory.clement@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: mvebu: Can we make the orion-mdio clock a requirement?
Date: Mon, 21 Jul 2014 21:28:18 +0200 [thread overview]
Message-ID: <20140721212818.2d4920c4@free-electrons.com> (raw)
In-Reply-To: <20140721190614.GB20027@arch.cereza>
Dear Ezequiel Garcia,
On Mon, 21 Jul 2014 16:06:15 -0300, Ezequiel Garcia wrote:
> Currently the mvmdio driver does not require a clock to be declared,
> and instead this is optional.
>
> However (almost) all the platforms that currently use it, i.e. the
> Armada, Kirkwood and Dove SoCs, require some clock to be enabled before
> the MDIO registers can be accessed.
>
> The Orion5x SoC doesn't declare any clock for neither the ethernet node,
> nor the MDIO node. Is that correct?
There are no gatable clocks on Orion5x, so unless the driver really
wants a clock, there's no hard requirement to give a clock reference.
> Do you think we could make the clock a required property in the mvmdio
> devicetree node? How would that behave in the non-DT case?
I don't think the mvmdio driver is used in non-DT contexts.
However, yes, I tend to agree, making the clock mandatory would
probably be a good thing.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-07-21 19:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 19:06 mvebu: Can we make the orion-mdio clock a requirement? Ezequiel Garcia
2014-07-21 19:28 ` Thomas Petazzoni [this message]
2014-07-21 20:12 ` Sebastian Hesselbarth
2014-07-21 20:23 ` Thomas Petazzoni
2014-07-22 23:46 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140721212818.2d4920c4@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).