Re: [PATCH net-next] cxgb4: Fix for SR-IOV VF initialization

[David Miller <davem@davemloft.net>]

From: Hariprasad Shenai <hariprasad@chelsio.com>
Date: Tue, 22 Jul 2014 16:26:20 +0530

> Commit 35b1de5 ("rdma/cxgb4: Fixes cxgb4 probe failure in VM when PF is exposed
> through PCI Passthrough") introduced a regression, where VF failed to
> initialize. This commit fixes it.
> 
> Signed-off-by: Casey Leedom <leedom@chelsio.com>
> Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>

This commit message need to explain things better, how exactly was
the regression introduced, what's exactly wrong with the current code?

I actually can't figure it out myself, other than to say that maybe
replacing things with:

	func = PCI_FUNC(pdev->devfn);
 	if (func < ARRAY_SIZE(num_vf) && num_vf[func] > 0)
 		if (pci_enable_sriov(pdev, num_vf[func]) == 0)

would work equally as well.  That's precisely what the code was
doing before the mentioned commit.

Why do we have to iterate over _ALL_ functions of the PCI device,
rather than just directly enable SRIOV on the one function whether
it bet PCI_FUNC(pdev->devfn) or that WHOAMI value?

You need to explain this so that people understand the how and the
why of your changes.

Thanks.