From: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH] atm: Remove fix me in solos-pci
Date: Tue, 22 Jul 2014 07:43:32 -0400 [thread overview]
Message-ID: <20140722074332.52b8c66b@thirdoffive.cmf.nrl.navy.mil> (raw)
In-Reply-To: <1406002040-7334-1-git-send-email-xerofoify@gmail.com>
Guy Ellis of Transverse says that Nathan Williams,
nathan@traverse.com.au, will address this issue when he returns
from vacation. So let's just wait for the 'official' fix.
On Tue, 22 Jul 2014 00:07:20 -0400
Nicholas Krause <xerofoify@gmail.com> wrote:
> This removes a fix me as the default statement for solos_bh is correct
> and needs no fixing.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/atm/solos-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
> index 943cf0d..58a0a8f 100644
> --- a/drivers/atm/solos-pci.c
> +++ b/drivers/atm/solos-pci.c
> @@ -851,7 +851,7 @@ static void solos_bh(unsigned long card_arg)
> break;
>
> case PKT_COMMAND:
> - default: /* FIXME: Not really, surely? */
> + default:
> if (process_command(card, port, skb))
> break;
> spin_lock(&card->cli_queue_lock);
next prev parent reply other threads:[~2014-07-22 11:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 4:07 [PATCH] atm: Remove fix me in solos-pci Nicholas Krause
2014-07-22 11:43 ` chas williams - CONTRACTOR [this message]
2014-07-22 17:47 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722074332.52b8c66b@thirdoffive.cmf.nrl.navy.mil \
--to=chas@cmf.nrl.navy.mil \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).