From: David Miller <davem@davemloft.net>
To: willemb@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, richardcochran@gmail.com
Subject: Re: [PATCH net-next v3 1/5] net-timestamp: extend SCM_TIMESTAMPING ancillary data struct
Date: Wed, 23 Jul 2014 21:12:56 -0700 (PDT) [thread overview]
Message-ID: <20140723.211256.2143360320648788946.davem@davemloft.net> (raw)
In-Reply-To: <CA+FuTScobCk5EFgsht=S0mfF4fVh1fKqAAV8+mZLk9h1O_uwnA@mail.gmail.com>
From: Willem de Bruijn <willemb@google.com>
Date: Tue, 22 Jul 2014 11:45:30 -0400
> There are a few alternatives, but none as simple, so this is better
> left to a separate patch. With skb_shinfo(skb)->syststamp deprecated
> for all but the octeon legacy use case, it is possible to repurpose
> those bytes for new uses in a union, including for a new u16 ts_key.
> The sk would still have to grow by a new field, though, e.g.,
> ts_counter. I have to think about this a bit more first.
I can't believe we're going to hold onto syststamp just for one
odd-ball MIPS ethernet driver. Really?
I think putting in whatever work is necessary to convert Octeon over
to exposing a proper PTP device is much better than having this
syststamp thing rot in our data structures forever.
next prev parent reply other threads:[~2014-07-24 4:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 19:35 [PATCH net-next v3 0/5] net-timestamp: additional sw tstamps and bytestream support Willem de Bruijn
2014-07-21 19:35 ` [PATCH net-next v3 1/5] net-timestamp: extend SCM_TIMESTAMPING ancillary data struct Willem de Bruijn
2014-07-21 23:24 ` David Miller
2014-07-22 15:45 ` Willem de Bruijn
2014-07-24 4:12 ` David Miller [this message]
2014-07-24 20:48 ` Willem de Bruijn
2014-07-24 21:15 ` David Miller
2014-07-24 23:05 ` Willem de Bruijn
2014-07-24 23:50 ` David Miller
2014-07-25 0:10 ` Willem de Bruijn
2014-07-25 0:53 ` David Miller
2014-07-21 19:35 ` [PATCH net-next v3 2/5] net-timestamp: move timestamp flags out of sk_flags Willem de Bruijn
2014-07-21 19:35 ` [PATCH net-next v3 3/5] net-timestamp: ENQ timestamp on enqueue to traffic shaping layer Willem de Bruijn
2014-07-21 19:35 ` [PATCH net-next v3 4/5] net-timestamp: TCP timestamping Willem de Bruijn
2014-07-21 19:35 ` [PATCH net-next v3 5/5] net-timestamp: ACK timestamp for bytestreams Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723.211256.2143360320648788946.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).