From: David Miller <davem@davemloft.net>
To: willemb@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
richardcochran@gmail.com, david.daney@cavium.net,
kreese@caviumnetworks.com
Subject: Re: [PATCH net-next v3 1/5] net-timestamp: extend SCM_TIMESTAMPING ancillary data struct
Date: Thu, 24 Jul 2014 14:15:28 -0700 (PDT) [thread overview]
Message-ID: <20140724.141528.1823901044834131393.davem@davemloft.net> (raw)
In-Reply-To: <CA+FuTSfMzbvGAM--LmB6i1R5cGZchmQqMNYkbcQGBn6jRAWG9A@mail.gmail.com>
From: Willem de Bruijn <willemb@google.com>
Date: Thu, 24 Jul 2014 16:48:04 -0400
>> I can't believe we're going to hold onto syststamp just for one
>> odd-ball MIPS ethernet driver. Really?
>>
>> I think putting in whatever work is necessary to convert Octeon over
>> to exposing a proper PTP device is much better than having this
>> syststamp thing rot in our data structures forever.
>
> Implementing ptp_clock_info gettime/settime/adjtime/adjfreq using
> CVMX_MIO_PTP_CLOCK_[CFG|HI|COMP] might be feasible.
>
> That does not address legacy application dependencies on syststamp.
> Even with a PTP device, it is unclear whether anyone would invest time
> to convert their application to use it. The most relevant code I could
> find is cavium ptp-1588v2 on github. That configures SO_TIMESTAMPING
> to generate both raw + sys tstamps and preferentially reads the first.
> If this is the only known octeon timestamping user, then it would be
> just as safe to simply remove syststamp.
The kernel would simply saw that adjusted HW timestamps are not
supported, the application has to accomodate the possibility of
needing to use one of the other timestamping flavors.
next prev parent reply other threads:[~2014-07-24 21:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 19:35 [PATCH net-next v3 0/5] net-timestamp: additional sw tstamps and bytestream support Willem de Bruijn
2014-07-21 19:35 ` [PATCH net-next v3 1/5] net-timestamp: extend SCM_TIMESTAMPING ancillary data struct Willem de Bruijn
2014-07-21 23:24 ` David Miller
2014-07-22 15:45 ` Willem de Bruijn
2014-07-24 4:12 ` David Miller
2014-07-24 20:48 ` Willem de Bruijn
2014-07-24 21:15 ` David Miller [this message]
2014-07-24 23:05 ` Willem de Bruijn
2014-07-24 23:50 ` David Miller
2014-07-25 0:10 ` Willem de Bruijn
2014-07-25 0:53 ` David Miller
2014-07-21 19:35 ` [PATCH net-next v3 2/5] net-timestamp: move timestamp flags out of sk_flags Willem de Bruijn
2014-07-21 19:35 ` [PATCH net-next v3 3/5] net-timestamp: ENQ timestamp on enqueue to traffic shaping layer Willem de Bruijn
2014-07-21 19:35 ` [PATCH net-next v3 4/5] net-timestamp: TCP timestamping Willem de Bruijn
2014-07-21 19:35 ` [PATCH net-next v3 5/5] net-timestamp: ACK timestamp for bytestreams Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140724.141528.1823901044834131393.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.daney@cavium.net \
--cc=eric.dumazet@gmail.com \
--cc=kreese@caviumnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).