* [PATCH] igmp: remove exceptional & on function name
@ 2014-07-24 20:18 Himangi Saraogi
2014-07-25 6:25 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Himangi Saraogi @ 2014-07-24 20:18 UTC (permalink / raw)
To: David S. Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy, netdev, linux-kernel
Cc: Julia Lawall
In this file, function names are otherwise used as pointers without &.
A simplified version of the Coccinelle semantic patch that makes this
change is as follows:
// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
net/ipv4/igmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
index db710b0..f10eab4 100644
--- a/net/ipv4/igmp.c
+++ b/net/ipv4/igmp.c
@@ -1321,7 +1321,7 @@ void ip_mc_inc_group(struct in_device *in_dev, __be32 addr)
atomic_set(&im->refcnt, 1);
spin_lock_init(&im->lock);
#ifdef CONFIG_IP_MULTICAST
- setup_timer(&im->timer, &igmp_timer_expire, (unsigned long)im);
+ setup_timer(&im->timer, igmp_timer_expire, (unsigned long)im);
im->unsolicit_count = IGMP_Unsolicited_Report_Count;
#endif
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] igmp: remove exceptional & on function name
2014-07-24 20:18 [PATCH] igmp: remove exceptional & on function name Himangi Saraogi
@ 2014-07-25 6:25 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-07-25 6:25 UTC (permalink / raw)
To: himangi774
Cc: kuznet, jmorris, yoshfuji, kaber, netdev, linux-kernel,
julia.lawall
From: Himangi Saraogi <himangi774@gmail.com>
Date: Fri, 25 Jul 2014 01:48:44 +0530
> In this file, function names are otherwise used as pointers without &.
>
> A simplified version of the Coccinelle semantic patch that makes this
> change is as follows:
...
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-25 6:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-24 20:18 [PATCH] igmp: remove exceptional & on function name Himangi Saraogi
2014-07-25 6:25 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).