From: Richard Cochran <richardcochran@gmail.com>
To: Willem de Bruijn <willemb@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
kreese@caviumnetworks.com, ddaney@caviumnetworks.com,
dborkman@redhat.com, jdmason@kudzu.us
Subject: Re: [net-next 0/4] remove deprecated syststamp
Date: Sat, 26 Jul 2014 09:45:47 +0200 [thread overview]
Message-ID: <20140726074545.GA4472@netboy> (raw)
In-Reply-To: <1406325692-616-1-git-send-email-willemb@google.com>
On Fri, Jul 25, 2014 at 06:01:28PM -0400, Willem de Bruijn wrote:
> The remaining driver (octeon) does not expose such a standard
> interface as of now. It does have its own PTP library that depends
> on its own shared memory PTP clock interface.
FWIW, that custom interface isn't even part of the kernel. It was nice
of you to take the trouble to find out about it, and it seems that
removing the SYS time stamp will not hurt applications using the
custom interface. They will need a custom kernel in any case. However,
at the end of the day, we really don't have to support random
out-of-tree interfaces.
> This patchset
> 1. reverts the syststamp code in the one driver (octeon)
> 2. reverts an unnecessary zero initialization in another (vxge)
> 3. modifies PF_PACKET to use syststamp is != 0 (because always == 0)
> 4. modifies SCM_TIMESTAMPING in the same way
Thanks for doing this series.
Acked-by: Richard Cochran <richardcochran@gmail.com>
next prev parent reply other threads:[~2014-07-26 7:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 22:01 [net-next 0/4] remove deprecated syststamp Willem de Bruijn
2014-07-25 22:01 ` [net-next 1/4] octeon: remove deprecated syststamp timestamp Willem de Bruijn
2014-07-25 22:01 ` [net-next 2/4] vxge: " Willem de Bruijn
2014-07-25 22:01 ` [net-next 3/4] packet: " Willem de Bruijn
2014-07-25 22:01 ` [net-next 4/4] net: " Willem de Bruijn
2014-07-26 7:45 ` Richard Cochran [this message]
2014-07-29 18:40 ` [net-next 0/4] remove deprecated syststamp David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140726074545.GA4472@netboy \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=ddaney@caviumnetworks.com \
--cc=jdmason@kudzu.us \
--cc=kreese@caviumnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).