From: David Miller <davem@davemloft.net>
To: ben@decadent.org.uk
Cc: sshah@solarflare.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] sfc: Use __iowrite64_copy instead of a slightly different local function
Date: Tue, 29 Jul 2014 15:30:48 -0700 (PDT) [thread overview]
Message-ID: <20140729.153048.1378087192291832153.davem@davemloft.net> (raw)
In-Reply-To: <1406427279.29010.139.camel@deadeye.wl.decadent.org.uk>
From: Ben Hutchings <ben@decadent.org.uk>
Date: Sun, 27 Jul 2014 03:14:39 +0100
> __iowrite64_copy() isn't quite the same as efx_memcpy_64(), but
> it looks close enough:
>
> - The length is in units of qwords not bytes
> - It never byte-swaps, but that doesn't make a difference now as PIO
> is only enabled for x86_64
> - It doesn't include any memory barriers, but that's OK as there is a
> barrier just before pushing the doorbell
> - mlx4_en uses it for the same purpose
>
> Compile-tested only.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Applied, thanks.
prev parent reply other threads:[~2014-07-29 22:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-27 2:14 [PATCH net-next] sfc: Use __iowrite64_copy instead of a slightly different local function Ben Hutchings
2014-07-29 15:03 ` Edward Cree
2014-07-29 22:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729.153048.1378087192291832153.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=netdev@vger.kernel.org \
--cc=sshah@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).