* [PATCH] openvswitch: Use IS_ERR_OR_NULL
@ 2014-07-27 7:07 Himangi Saraogi
2014-07-28 20:37 ` Pravin Shelar
2014-07-29 22:32 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Himangi Saraogi @ 2014-07-27 7:07 UTC (permalink / raw)
To: Pravin Shelar, David S. Miller, dev-yBygre7rU0TnMu66kgdUjQ,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Julia Lawall
This patch introduces the use of the macro IS_ERR_OR_NULL in place of
tests for NULL and IS_ERR.
The following Coccinelle semantic patch was used for making the change:
@@
expression e;
@@
- e == NULL || IS_ERR(e)
+ IS_ERR_OR_NULL(e)
|| ...
Signed-off-by: Himangi Saraogi <himangi774-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Acked-by: Julia Lawall <julia.lawall-L2FTfq7BK8M@public.gmane.org>
---
net/openvswitch/datapath.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
index 20f59b6..e3b3c21 100644
--- a/net/openvswitch/datapath.c
+++ b/net/openvswitch/datapath.c
@@ -780,7 +780,7 @@ static struct sk_buff *ovs_flow_cmd_build_info(const struct sw_flow *flow,
skb = ovs_flow_cmd_alloc_info(ovsl_dereference(flow->sf_acts), info,
always);
- if (!skb || IS_ERR(skb))
+ if (IS_ERR_OR_NULL(skb))
return skb;
retval = ovs_flow_cmd_fill_info(flow, dp_ifindex, skb,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] openvswitch: Use IS_ERR_OR_NULL
2014-07-27 7:07 [PATCH] openvswitch: Use IS_ERR_OR_NULL Himangi Saraogi
@ 2014-07-28 20:37 ` Pravin Shelar
2014-07-29 22:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Pravin Shelar @ 2014-07-28 20:37 UTC (permalink / raw)
To: Himangi Saraogi
Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, netdev, Julia Lawall,
David S. Miller, LKML
On Sun, Jul 27, 2014 at 12:07 AM, Himangi Saraogi <himangi774-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> This patch introduces the use of the macro IS_ERR_OR_NULL in place of
> tests for NULL and IS_ERR.
>
> The following Coccinelle semantic patch was used for making the change:
>
> @@
> expression e;
> @@
>
> - e == NULL || IS_ERR(e)
> + IS_ERR_OR_NULL(e)
> || ...
>
> Signed-off-by: Himangi Saraogi <himangi774-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Acked-by: Julia Lawall <julia.lawall-L2FTfq7BK8M@public.gmane.org>
Looks good.
Acked-by: Pravin B Shelar <pshelar-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
> ---
> net/openvswitch/datapath.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
> index 20f59b6..e3b3c21 100644
> --- a/net/openvswitch/datapath.c
> +++ b/net/openvswitch/datapath.c
> @@ -780,7 +780,7 @@ static struct sk_buff *ovs_flow_cmd_build_info(const struct sw_flow *flow,
>
> skb = ovs_flow_cmd_alloc_info(ovsl_dereference(flow->sf_acts), info,
> always);
> - if (!skb || IS_ERR(skb))
> + if (IS_ERR_OR_NULL(skb))
> return skb;
>
> retval = ovs_flow_cmd_fill_info(flow, dp_ifindex, skb,
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] openvswitch: Use IS_ERR_OR_NULL
2014-07-27 7:07 [PATCH] openvswitch: Use IS_ERR_OR_NULL Himangi Saraogi
2014-07-28 20:37 ` Pravin Shelar
@ 2014-07-29 22:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-07-29 22:32 UTC (permalink / raw)
To: himangi774; +Cc: pshelar, dev, netdev, linux-kernel, julia.lawall
From: Himangi Saraogi <himangi774@gmail.com>
Date: Sun, 27 Jul 2014 12:37:46 +0530
> This patch introduces the use of the macro IS_ERR_OR_NULL in place of
> tests for NULL and IS_ERR.
>
> The following Coccinelle semantic patch was used for making the change:
>
> @@
> expression e;
> @@
>
> - e == NULL || IS_ERR(e)
> + IS_ERR_OR_NULL(e)
> || ...
>
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-29 22:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-27 7:07 [PATCH] openvswitch: Use IS_ERR_OR_NULL Himangi Saraogi
2014-07-28 20:37 ` Pravin Shelar
2014-07-29 22:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).