From: Christoph Paasch <christoph.paasch@uclouvain.be>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, ncardwell@google.com,
David.Laight@ACULAB.COM, doug.leith@nuim.ie
Subject: Re: [PATCH v2 net] tcp: Fix integer-overflows in TCP vegas
Date: Tue, 29 Jul 2014 11:52:27 +0200 [thread overview]
Message-ID: <20140729095227.GD5038@cpaasch-mac> (raw)
In-Reply-To: <20140728.172627.1679434888082672835.davem@davemloft.net>
On 28/07/14 - 17:26:27, David Miller wrote:
> From: Christoph Paasch <christoph.paasch@uclouvain.be>
> Date: Fri, 25 Jul 2014 13:52:39 +0200
>
> > + target_cwnd = U32_MAX / rtt * upper + err / rtt;
>
> Doing two divides is probably more expensive than using do_div().
>
> Why don't we go back to the do_div() implementation, sorry about
> changing my mind again.
No worries :)
I will resubmit.
Cheers,
Christoph
prev parent reply other threads:[~2014-07-29 9:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 11:52 [PATCH v2 net] tcp: Fix integer-overflows in TCP vegas Christoph Paasch
2014-07-25 18:14 ` Stephen Hemminger
2014-07-26 8:59 ` Christoph Paasch
2014-07-26 9:54 ` Eric Dumazet
2014-07-27 9:48 ` Christoph Paasch
2014-07-29 0:26 ` David Miller
2014-07-29 9:52 ` Christoph Paasch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729095227.GD5038@cpaasch-mac \
--to=christoph.paasch@uclouvain.be \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=doug.leith@nuim.ie \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).