From: David Miller <davem@davemloft.net>
To: christoph.paasch@uclouvain.be
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH RESUBMIT net] tcp: Fix integer-overflows in TCP veno
Date: Wed, 30 Jul 2014 17:31:34 -0700 (PDT) [thread overview]
Message-ID: <20140730.173134.865256818780740961.davem@davemloft.net> (raw)
In-Reply-To: <1406628447-21130-1-git-send-email-christoph.paasch@uclouvain.be>
From: Christoph Paasch <christoph.paasch@uclouvain.be>
Date: Tue, 29 Jul 2014 12:07:27 +0200
> In veno we do a multiplication of the cwnd and the rtt. This
> may overflow and thus their result is stored in a u64. However, we first
> need to cast the cwnd so that actually 64-bit arithmetic is done.
>
> A first attempt at fixing 76f1017757aa0 ([TCP]: TCP Veno congestion
> control) was made by 159131149c2 (tcp: Overflow bug in Vegas), but it
> failed to add the required cast in tcp_veno_cong_avoid().
>
> Fixes: 76f1017757aa0 ([TCP]: TCP Veno congestion control)
> Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>
Applied and queued up for -stable.
prev parent reply other threads:[~2014-07-31 0:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 10:07 [PATCH RESUBMIT net] tcp: Fix integer-overflows in TCP veno Christoph Paasch
2014-07-31 0:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730.173134.865256818780740961.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=christoph.paasch@uclouvain.be \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).