From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 1/2 v2 net-next] netfilter: xt_bpf: add mising opaque struct sk_filter definition Date: Wed, 30 Jul 2014 19:57:04 -0700 (PDT) Message-ID: <20140730.195704.1972856285516371876.davem@davemloft.net> References: <1406650335-5916-1-git-send-email-pablo@netfilter.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, ast@plumgrid.com, keescook@chromium.org, willemb@google.com, dborkman@redhat.com To: pablo@netfilter.org Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:38778 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755270AbaGaC5I (ORCPT ); Wed, 30 Jul 2014 22:57:08 -0400 In-Reply-To: <1406650335-5916-1-git-send-email-pablo@netfilter.org> Sender: netdev-owner@vger.kernel.org List-ID: From: Pablo Neira Ayuso Date: Tue, 29 Jul 2014 18:12:15 +0200 > This structure is not exposed to userspace, so fix this by defining > struct sk_filter; so we skip the casting in kernelspace. This is safe > since userspace has no way to lurk with that internal pointer. > > Fixes: e6f30c7 ("netfilter: x_tables: add xt_bpf match") > Signed-off-by: Pablo Neira Ayuso > --- > v2: address Willem's feedback, we still need uapi/linux/filter.h for > userspace iptables builds. Applied.