From: Eli Cohen <eli@dev.mellanox.co.il>
To: Or Gerlitz <or.gerlitz@gmail.com>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Roland Dreier <roland@kernel.org>,
Jack Morgenstein <jackm@dev.mellanox.co.il>,
Eli Cohen <eli@mellanox.com>,
Yevgeny Petrilin <yevgenyp@mellanox.com>
Subject: Re: [PATCH net-next 1/3] mlx5: Move pci device handling from mlx5_ib to mlx5_core
Date: Wed, 30 Jul 2014 13:26:15 +0300 [thread overview]
Message-ID: <20140730102615.GA24716@mtldesk30> (raw)
In-Reply-To: <CAJZOPZLyhh6pGSwFHOe8oCc4a3xVTdCHric6sH78Kz5Dr7NvLw@mail.gmail.com>
On Mon, Jul 28, 2014 at 11:57:37PM +0300, Or Gerlitz wrote:
>
> You need to issue a warning here if someone attempts to change the
> previously default value of the now deprecated module param. E.g warn
> this is deprecated and point them to mlx5_core
>
It is handled in the module init function:
static int __init mlx5_ib_init(void)
{
- return pci_register_driver(&mlx5_ib_driver);
+ if (deprecated_prof_sel != 2)
+ pr_warn("prof_sel is deprecated for mlx5_ib, set it
for mlx5_core\n");
+
+ return mlx5_register_interface(&mlx5_ib_interface);
}
next prev parent reply other threads:[~2014-07-30 10:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 20:30 [PATCH net-next 0/3] mlx5 driver changes related to PCI handling *** Eli Cohen
2014-07-28 20:30 ` [PATCH net-next 1/3] mlx5: Move pci device handling from mlx5_ib to mlx5_core Eli Cohen
2014-07-28 20:57 ` Or Gerlitz
2014-07-30 10:26 ` Eli Cohen [this message]
2014-07-30 20:57 ` Or Gerlitz
2014-07-28 20:30 ` [PATCH net-next 2/3] mlx5: minor fixes (mainly avoidance of hidden casts) Eli Cohen
2014-07-28 20:30 ` [PATCH net-next 3/3] mlx5: Adjust events to use unsigned long param instead of void * Eli Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730102615.GA24716@mtldesk30 \
--to=eli@dev.mellanox.co.il \
--cc=davem@davemloft.net \
--cc=eli@mellanox.com \
--cc=jackm@dev.mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=roland@kernel.org \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).