netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: David Hendel <david@silicom.co.il>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Anna Lukin <annal@silicom.co.il>
Subject: Re: FW: ethtool patch to support bypass / fail-to-wire function
Date: Thu, 31 Jul 2014 00:03:43 +0200	[thread overview]
Message-ID: <20140730220343.GA309@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <3BFAEADE799AF145974162DF00E013AF018F803DED@exchange2010.silicom.local>

David Hendel <david@silicom.co.il> :
[...]
> We have our bypass driver updated and we would like to move forward with
> integrating it into the kernel.
> We think it need to be under drivers/net/
> 
> The description is per the below, taken from readme in linux.
> The patch is attached,
> Let me know how we can proceed with that. what should be the next step.

Executive summary: this code does not even remotely look like network
kernel code. The patch completely messes code that had been reworked
in drivers/staging.

It's very embarrassing.

-- 
Ueimor

      reply	other threads:[~2014-07-30 22:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3BFAEADE799AF145974162DF00E013AF018F794DE5@exchange2010.silicom.local>
     [not found] ` <1402322812.23860.76.camel@deadeye.wl.decadent.org.uk>
2014-06-09 20:27   ` ethtool patch to support bypass / fail-to-wire function David Hendel
2014-06-11  7:06   ` David Hendel
2014-06-11 16:17     ` Stephen Hemminger
2014-06-11 16:55       ` David Hendel
2014-06-11 18:35         ` Stephen Hemminger
2014-07-30 12:55           ` FW: " David Hendel
2014-07-30 22:03             ` Francois Romieu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140730220343.GA309@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=annal@silicom.co.il \
    --cc=david@silicom.co.il \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).