From: David Miller <davem@davemloft.net>
To: dborkman@redhat.com
Cc: netdev@vger.kernel.org, pablo@netfilter.org, ast@plumgrid.com,
jiri@resnulli.us
Subject: Re: [PATCH net-next] team: fix releasing uninitialized pointer to BPF prog
Date: Thu, 31 Jul 2014 13:10:29 -0700 (PDT) [thread overview]
Message-ID: <20140731.131029.385699833260567908.davem@davemloft.net> (raw)
In-Reply-To: <1406836139-11943-1-git-send-email-dborkman@redhat.com>
From: Daniel Borkmann <dborkman@redhat.com>
Date: Thu, 31 Jul 2014 21:48:59 +0200
> Commit 34c5bd66e5ed introduced the possibility that an
> uninitialized pointer on the stack (orig_fp) can call into
> sk_unattached_filter_destroy() when its value is non NULL.
>
> Before that commit orig_fp was only destroyed in the same
> block where it was assigned a valid BPF prog before. Fix it
> up by initializing it to NULL.
>
> Fixes: 34c5bd66e5ed ("net: filter: don't release unattached filter through call_rcu()")
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Applied, thanks Daniel.
prev parent reply other threads:[~2014-07-31 20:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 19:48 [PATCH net-next] team: fix releasing uninitialized pointer to BPF prog Daniel Borkmann
2014-07-31 20:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140731.131029.385699833260567908.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@plumgrid.com \
--cc=dborkman@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).