From: David Miller <davem@davemloft.net>
To: aaron.f.brown@intel.com
Cc: akeem.g.abodunrin@intel.com, netdev@vger.kernel.org,
gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net-next 06/15] i40e: Move some variable declarations out of a loop
Date: Thu, 31 Jul 2014 14:05:59 -0700 (PDT) [thread overview]
Message-ID: <20140731.140559.2090702986159656213.davem@davemloft.net> (raw)
In-Reply-To: <1406766731-4209-7-git-send-email-aaron.f.brown@intel.com>
From: Aaron Brown <aaron.f.brown@intel.com>
Date: Wed, 30 Jul 2014 17:32:02 -0700
> From: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>
>
> Declare some variables once outside of the loop instead of in
> every iteration of the loop.
>
> Change-ID: I436913777c7da3c16dc0031b59e3ffa61de74718
> Signed-off-by: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>
> Tested-by: Jim Young <jamesx.m.young@intel.com>
> Signed-off-by: Aaron Brown <aaron.f.brown@intel.com>
Why? Decreasing the scope of variables makes the code easier to
understand and audit.
Now that it's declared at the top level people have to check whether
is it initialized properly in all possible code paths, in the entire
function, rather than just inside of the loop.
Please respin this series with this patch removed, thanks.
next prev parent reply other threads:[~2014-07-31 21:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 0:31 [net-next 00/15] Intel Wired LAN Driver Updates Aaron Brown
2014-07-31 0:31 ` [net-next 01/15] i40e: adds FCoE code to the i40e driver Aaron Brown
2014-07-31 0:31 ` [net-next 02/15] i40e: Adds FCoE related code to i40e core driver Aaron Brown
2014-07-31 0:31 ` [net-next 03/15] i40e: adds FCoE to build and updates its documentation Aaron Brown
2014-07-31 0:32 ` [net-next 04/15] i40e: expose debug_write_register request Aaron Brown
2014-07-31 0:32 ` [net-next 05/15] i40e: use correct vf_id offset for virtchnl message Aaron Brown
2014-07-31 0:32 ` [net-next 06/15] i40e: Move some variable declarations out of a loop Aaron Brown
2014-07-31 21:05 ` David Miller [this message]
2014-07-31 23:56 ` Abodunrin, Akeem G
2014-08-01 1:31 ` David Miller
2014-07-31 0:32 ` [net-next 07/15] i40e: disable local loopback on vmdq vsi Aaron Brown
2014-07-31 0:32 ` [net-next 08/15] i40evf: fix scan warning on sprintf Aaron Brown
2014-07-31 0:32 ` [net-next 09/15] i40e: Minor comment changes Aaron Brown
2014-07-31 0:32 ` [net-next 10/15] i40e: remove support for vf unicast promiscuous mode Aaron Brown
2014-07-31 0:32 ` [net-next 11/15] i40evf: future-proof vfr_stat state check Aaron Brown
2014-07-31 0:32 ` [net-next 12/15] i40evf: do not re-arm watchdog after remove Aaron Brown
2014-07-31 0:32 ` [net-next 13/15] i40evf: don't leak queue vectors Aaron Brown
2014-07-31 0:32 ` [net-next 14/15] i40evf: fix memory leak on unused interfaces Aaron Brown
2014-07-31 0:32 ` [net-next 15/15] i40evf: Fixed guest OS panic when removing vf driver Aaron Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140731.140559.2090702986159656213.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aaron.f.brown@intel.com \
--cc=akeem.g.abodunrin@intel.com \
--cc=gospo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).