From: David Miller <davem@davemloft.net>
To: kys@microsoft.com
Cc: olaf@aepfle.de, netdev@vger.kernel.org, jasowang@redhat.com,
linux-kernel@vger.kernel.org, apw@canonical.com,
devel@linuxdriverproject.org
Subject: Re: [PATCH 1/1] Drivers: net-next: hyperv: Increase the size of the sendbuf region
Date: Thu, 31 Jul 2014 21:59:07 -0700 (PDT) [thread overview]
Message-ID: <20140731.215907.860867918938148695.davem@davemloft.net> (raw)
In-Reply-To: <1406770549-29982-1-git-send-email-kys@microsoft.com>
From: "K. Y. Srinivasan" <kys@microsoft.com>
Date: Wed, 30 Jul 2014 18:35:49 -0700
> For forwarding scenarios, it will be useful to allocate larger
> sendbuf. Make the necessary adjustments to permit this.
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
This needs more information.
You're increasing the size by 16 times, 1MB --> 16MB, thus less
cache locality.
You're also now using vmalloc() memory, thus more TLB misses and
thrashing.
This must have a negative impact on performance, and you have to
test for that and quantify it when making a change as serious as
this one.
You also haven't gone into detail as to why forwarding scenerios
require more buffer space, than say thousands of local sockets
sending bulk TCP data.
I'm not applying this, it needs a lot more work.
next prev parent reply other threads:[~2014-08-01 4:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 1:35 [PATCH 1/1] Drivers: net-next: hyperv: Increase the size of the sendbuf region K. Y. Srinivasan
2014-08-01 4:59 ` David Miller [this message]
2014-08-01 17:51 ` KY Srinivasan
2014-08-02 6:14 ` David Miller
2014-08-02 16:18 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140731.215907.860867918938148695.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).