* [PATCH net-next] bonding: use kobject_put instead of _del after kobject_add
@ 2014-07-29 11:27 Veaceslav Falico
2014-07-31 0:37 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Veaceslav Falico @ 2014-07-29 11:27 UTC (permalink / raw)
To: netdev; +Cc: Veaceslav Falico, Jay Vosburgh, Andy Gospodarek
Otherwise the name of the kobject isn't getting freed and other stuff from
kobject_cleanup() isn't getting called. kobject_put() will call
kobject_del() on its own in kobject_cleanup().
CC: Jay Vosburgh <j.vosburgh@gmail.com>
CC: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: Veaceslav Falico <vfalico@gmail.com>
---
drivers/net/bonding/bond_sysfs_slave.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bonding/bond_sysfs_slave.c b/drivers/net/bonding/bond_sysfs_slave.c
index 198677f..5cd532c 100644
--- a/drivers/net/bonding/bond_sysfs_slave.c
+++ b/drivers/net/bonding/bond_sysfs_slave.c
@@ -125,7 +125,7 @@ int bond_sysfs_slave_add(struct slave *slave)
for (a = slave_attrs; *a; ++a) {
err = sysfs_create_file(&slave->kobj, &((*a)->attr));
if (err) {
- kobject_del(&slave->kobj);
+ kobject_put(&slave->kobj);
return err;
}
}
@@ -140,5 +140,5 @@ void bond_sysfs_slave_del(struct slave *slave)
for (a = slave_attrs; *a; ++a)
sysfs_remove_file(&slave->kobj, &((*a)->attr));
- kobject_del(&slave->kobj);
+ kobject_put(&slave->kobj);
}
--
1.8.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] bonding: use kobject_put instead of _del after kobject_add
2014-07-29 11:27 [PATCH net-next] bonding: use kobject_put instead of _del after kobject_add Veaceslav Falico
@ 2014-07-31 0:37 ` David Miller
2014-07-31 10:46 ` Veaceslav Falico
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2014-07-31 0:37 UTC (permalink / raw)
To: vfalico; +Cc: netdev, j.vosburgh, andy
From: Veaceslav Falico <vfalico@gmail.com>
Date: Tue, 29 Jul 2014 13:27:43 +0200
> Otherwise the name of the kobject isn't getting freed and other stuff from
> kobject_cleanup() isn't getting called. kobject_put() will call
> kobject_del() on its own in kobject_cleanup().
>
> CC: Jay Vosburgh <j.vosburgh@gmail.com>
> CC: Andy Gospodarek <andy@greyhouse.net>
> Signed-off-by: Veaceslav Falico <vfalico@gmail.com>
Introduced in v3.14, so maybe steer this to 'net' instead?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] bonding: use kobject_put instead of _del after kobject_add
2014-07-31 0:37 ` David Miller
@ 2014-07-31 10:46 ` Veaceslav Falico
2014-07-31 18:16 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Veaceslav Falico @ 2014-07-31 10:46 UTC (permalink / raw)
To: David Miller; +Cc: netdev, j.vosburgh, andy
On Wed, Jul 30, 2014 at 05:37:43PM -0700, David Miller wrote:
>From: Veaceslav Falico <vfalico@gmail.com>
>Date: Tue, 29 Jul 2014 13:27:43 +0200
>
>> Otherwise the name of the kobject isn't getting freed and other stuff from
>> kobject_cleanup() isn't getting called. kobject_put() will call
>> kobject_del() on its own in kobject_cleanup().
>>
>> CC: Jay Vosburgh <j.vosburgh@gmail.com>
>> CC: Andy Gospodarek <andy@greyhouse.net>
>> Signed-off-by: Veaceslav Falico <vfalico@gmail.com>
>
>Introduced in v3.14, so maybe steer this to 'net' instead?
Good idea. Should I re-send it or can you just apply it to net?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] bonding: use kobject_put instead of _del after kobject_add
2014-07-31 10:46 ` Veaceslav Falico
@ 2014-07-31 18:16 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2014-07-31 18:16 UTC (permalink / raw)
To: vfalico; +Cc: netdev, j.vosburgh, andy
From: Veaceslav Falico <vfalico@gmail.com>
Date: Thu, 31 Jul 2014 12:46:01 +0200
> On Wed, Jul 30, 2014 at 05:37:43PM -0700, David Miller wrote:
>>From: Veaceslav Falico <vfalico@gmail.com>
>>Date: Tue, 29 Jul 2014 13:27:43 +0200
>>
>>> Otherwise the name of the kobject isn't getting freed and other stuff
>>> from
>>> kobject_cleanup() isn't getting called. kobject_put() will call
>>> kobject_del() on its own in kobject_cleanup().
>>>
>>> CC: Jay Vosburgh <j.vosburgh@gmail.com>
>>> CC: Andy Gospodarek <andy@greyhouse.net>
>>> Signed-off-by: Veaceslav Falico <vfalico@gmail.com>
>>
>>Introduced in v3.14, so maybe steer this to 'net' instead?
>
> Good idea. Should I re-send it or can you just apply it to net?
I'll just apply it, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-31 18:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-29 11:27 [PATCH net-next] bonding: use kobject_put instead of _del after kobject_add Veaceslav Falico
2014-07-31 0:37 ` David Miller
2014-07-31 10:46 ` Veaceslav Falico
2014-07-31 18:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).