From: Florian Westphal <fw@strlen.de>
To: Nikolay Aleksandrov <nikolay@redhat.com>
Cc: netdev@vger.kernel.org, Florian Westphal <fw@strlen.de>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
Alexander Aring <alex.aring@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next 2/4] inet: frags: rename last_in to flags, enum the definitions and add comments
Date: Thu, 31 Jul 2014 23:26:15 +0200 [thread overview]
Message-ID: <20140731212615.GG23865@breakpoint.cc> (raw)
In-Reply-To: <1406819499-11198-3-git-send-email-nikolay@redhat.com>
Nikolay Aleksandrov <nikolay@redhat.com> wrote:
> The last_in field has been used to store various flags different from
> first/last frag in so give it a more descriptive name: flags. Move
> the flags to an enum definion, swap FIRST_IN/LAST_IN to be in logical
> order and add comments explaining each flag, also add comments explaining
> the inet_frag_queue struct members. While at it align some function
> declarations.
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2014-07-31 21:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 15:11 [PATCH net-next 0/4] inet: frags: cleanup and kmem_cache use Nikolay Aleksandrov
2014-07-31 15:11 ` [PATCH net-next 1/4] inet: frags: use INC_STATS_BH in the ipv6 reassembly code Nikolay Aleksandrov
2014-07-31 21:43 ` Hannes Frederic Sowa
2014-07-31 15:11 ` [PATCH net-next 2/4] inet: frags: rename last_in to flags, enum the definitions and add comments Nikolay Aleksandrov
2014-07-31 21:26 ` Florian Westphal [this message]
2014-08-01 5:13 ` David Miller
2014-08-01 8:27 ` Nikolay Aleksandrov
2014-07-31 15:11 ` [PATCH net-next 3/4] inet: frags: use INET_FRAG_EVICTED to prevent icmp messages Nikolay Aleksandrov
2014-07-31 21:23 ` Florian Westphal
2014-07-31 15:11 ` [PATCH net-next 4/4] inet: frags: use kmem_cache for inet_frag_queue Nikolay Aleksandrov
2014-07-31 21:29 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140731212615.GG23865@breakpoint.cc \
--to=fw@strlen.de \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).