From: David Miller <davem@davemloft.net>
To: festevam@gmail.com
Cc: f.fainelli@gmail.com, linux@arm.linux.org.uk,
shawn.guo@freescale.com, netdev@vger.kernel.org,
ezequiel.garcia@free-electrons.com, fabio.estevam@freescale.com,
stable@vger.kernel.org
Subject: Re: [PATCH] Revert "net: phy: Set the driver when registering an MDIO bus device"
Date: Tue, 05 Aug 2014 16:42:19 -0700 (PDT) [thread overview]
Message-ID: <20140805.164219.1353576887891215623.davem@davemloft.net> (raw)
In-Reply-To: <1407237222-3148-1-git-send-email-festevam@gmail.com>
From: Fabio Estevam <festevam@gmail.com>
Date: Tue, 5 Aug 2014 08:13:42 -0300
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Commit a71e3c37960ce5f9 ("net: phy: Set the driver when registering an MDIO bus
> device") caused the following regression on the fec driver:
...
> The problem with the original commit is explained by Russell King:
>
> "It has the effect (as can be seen from the oops) of attaching the MDIO bus
> device (itself is a bus-less device) to the platform driver, which means
> that if the platform driver supports power management, it will be called
> to power manage the MDIO bus device.
>
> Moreover, drivers do not expect to be called for power management
> operations for devices which they haven't probed, and certainly not for
> devices which aren't part of the same bus that the driver is registered
> against."
>
> This reverts commit a71e3c37960ce5f9c6a519bc1215e3ba9fa83e75.
>
> Cc: <stable@vger.kernel.org> #3.16
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied, and queued up for -stable, thanks.
prev parent reply other threads:[~2014-08-05 23:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 11:13 [PATCH] Revert "net: phy: Set the driver when registering an MDIO bus device" Fabio Estevam
2014-08-05 23:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140805.164219.1353576887891215623.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ezequiel.garcia@free-electrons.com \
--cc=f.fainelli@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@freescale.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).