From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [RFC][PATCH 0/7] nested sleeps, fixes and debug infra Date: Wed, 06 Aug 2014 14:16:03 -0700 (PDT) Message-ID: <20140806.141603.1422005306896590750.davem@davemloft.net> References: <20140805130646.GZ19379@twins.programming.kicks-ass.net> <20140806083134.GQ9918@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: ilya.dryomov@inktank.com, mingo@kernel.org, oleg@redhat.com, torvalds@linux-foundation.org, tglx@linutronix.de, umgwanakikbuti@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org To: peterz@infradead.org Return-path: In-Reply-To: <20140806083134.GQ9918@twins.programming.kicks-ass.net> Sender: owner-linux-mm@kvack.org List-Id: netdev.vger.kernel.org From: Peter Zijlstra Date: Wed, 6 Aug 2014 10:31:34 +0200 > On Wed, Aug 06, 2014 at 11:51:29AM +0400, Ilya Dryomov wrote: > >> OK, this one is a bit different. >> >> WARNING: CPU: 1 PID: 1744 at kernel/sched/core.c:7104 __might_sleep+0x58/0x90() >> do not call blocking ops when !TASK_RUNNING; state=1 set at [] prepare_to_wait+0x50 /0xa0 > >> [] __might_sleep+0x58/0x90 >> [] lock_sock_nested+0x31/0xb0 >> [] sk_stream_wait_memory+0x18a/0x2d0 > > Urgh, tedious. Its not an actual bug as is. Due to the condition check > in sk_wait_event() we can call lock_sock() with ->state != TASK_RUNNING. > > I'm not entirely sure what the cleanest way is to make this go away. > Possibly something like so: If you submit this formally to netdev with a signoff I'm willing to apply this if it helps the debug infrastructure. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org