From: David Miller <davem@davemloft.net>
To: willemb@google.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, richardcochran@gmail.com
Subject: Re: [PATCH net-next v4 5/6] net-timestamp: TCP timestamping
Date: Wed, 06 Aug 2014 14:32:13 -0700 (PDT) [thread overview]
Message-ID: <20140806.143213.1466007351572839621.davem@davemloft.net> (raw)
In-Reply-To: <CA+FuTSdnuBw4ex7Hj=ko_r0P7SqPs5gA2qcTX1tHMbo3YndMJQ@mail.gmail.com>
From: Willem de Bruijn <willemb@google.com>
Date: Wed, 6 Aug 2014 15:20:39 -0400
> On Wed, Aug 6, 2014 at 10:37 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> but also that we're going to send multiple reports back to error
>> queue.
>
> I see. The optimization patch to queue timestamps without payload will
> mitigate that somewhat. I dropped that from the initial patchset, but
> will fix it up for net-next. It may also be possible to squash
> multiple timestamped packets on the errqueue together when they all
> have the same payload, resulting in a single (possibly no-payload)
> packet with repeating cmsgs IP_RECVERR and SCM_TIMESTAMPING. That
> would give O(1) overhead regardless of number of retransmits.
We could attach a singly linked list of small sequence number cookies
to the SKB when it gets queued up.
Upon an ACK, we need only look at the entries at the front of the list
until we see one past the cumulative ACK.
There's a little bit of work to do when SKBs are coalesced or chopped
up, but in return the timestamp indications the user gets will be very
accurate.
next prev parent reply other threads:[~2014-08-06 21:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 2:11 [PATCH net-next v4 0/6] net-timestamp: new tx tstamps and tcp Willem de Bruijn
2014-08-05 2:11 ` [PATCH net-next v4 1/6] net-timestamp: extend SCM_TIMESTAMPING ancillary data struct Willem de Bruijn
2014-08-05 2:11 ` [PATCH net-next v4 2/6] net-timestamp: move timestamp flags out of sk_flags Willem de Bruijn
2014-08-05 2:11 ` [PATCH net-next v4 3/6] net-timestamp: add key to disambiguate concurrent datagrams Willem de Bruijn
2014-08-05 2:11 ` [PATCH net-next v4 4/6] net-timestamp: SCHED timestamp on entering packet scheduler Willem de Bruijn
2014-08-05 2:11 ` [PATCH net-next v4 5/6] net-timestamp: TCP timestamping Willem de Bruijn
2014-08-06 6:25 ` Eric Dumazet
2014-08-06 6:55 ` Eric Dumazet
2014-08-06 13:08 ` Willem de Bruijn
2014-08-06 14:36 ` Eric Dumazet
2014-08-06 7:05 ` Eric Dumazet
2014-08-06 9:49 ` [PATCH net-next] net-timestamp: sock_tx_timestamp() fix Eric Dumazet
2014-08-06 12:52 ` Willem de Bruijn
2014-08-06 19:38 ` David Miller
2014-08-06 14:23 ` [PATCH net-next v4 5/6] net-timestamp: TCP timestamping Willem de Bruijn
2014-08-06 14:37 ` Eric Dumazet
2014-08-06 19:20 ` Willem de Bruijn
2014-08-06 21:32 ` David Miller [this message]
2014-08-07 0:59 ` Willem de Bruijn
2014-08-07 2:03 ` David Miller
2014-08-07 3:43 ` Willem de Bruijn
2014-08-07 3:50 ` David Miller
2014-08-05 2:11 ` [PATCH net-next v4 6/6] net-timestamp: ACK timestamp for bytestreams Willem de Bruijn
2014-08-05 2:16 ` [PATCH net-next v4 0/6] net-timestamp: new tx tstamps and tcp Willem de Bruijn
2014-08-05 23:36 ` David Miller
2014-08-07 23:09 ` Andi Kleen
2014-08-07 23:39 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806.143213.1466007351572839621.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).