From: David Miller <davem@davemloft.net>
To: xerofoiify@gmail.com
Cc: petkan@nucleusys.com, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtl8150: Check if RSR is already defined
Date: Wed, 06 Aug 2014 22:36:11 -0700 (PDT) [thread overview]
Message-ID: <20140806.223611.1134627526934618200.davem@davemloft.net> (raw)
In-Reply-To: <1407389095-31426-1-git-send-email-xerofoiify@gmail.com>
From: Nick Krause <xerofoiify@gmail.com>
Date: Thu, 7 Aug 2014 07:24:54 +0200
> I am getting the following warn
>
> drivers/net/usb/rtl8150.c:30:0: warning: "RSR" redefined
> arch/xtensa/include/asm/processor.h:189:0: note: this is the location of the previous definition
>
> I wanted to remove RSR as it is not being used but it is not clear if being used
> for documenting purpose. undefining should be enough.
>
> Signed-off-by: Nick Krause <xerofoify@gmail.com>
This isn't the right way to fix this.
Rather, the thing to do is to give the macros in this driver an
appropriate prefix such as "RTL8150_" so that they don't collide
with things in the global namespace.
prev parent reply other threads:[~2014-08-07 5:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 5:24 [PATCH] rtl8150: Check if RSR is already defined Nick Krause
2014-08-07 5:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806.223611.1134627526934618200.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petkan@nucleusys.com \
--cc=xerofoiify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).