From: David Miller <davem@davemloft.net>
To: dborkman@redhat.com
Cc: netdev@vger.kernel.org, marcel@holtmann.org
Subject: Re: [PATCH net] netlink: reset network header before passing to taps
Date: Thu, 07 Aug 2014 16:06:17 -0700 (PDT) [thread overview]
Message-ID: <20140807.160617.1417231506028535686.davem@davemloft.net> (raw)
In-Reply-To: <1407442967-2109-1-git-send-email-dborkman@redhat.com>
From: Daniel Borkmann <dborkman@redhat.com>
Date: Thu, 7 Aug 2014 22:22:47 +0200
> netlink doesn't set any network header offset thus when the skb is
> being passed to tap devices via dev_queue_xmit_nit(), it emits klog
> false positives due to it being unset like:
>
> ...
> [ 124.990397] protocol 0000 is buggy, dev nlmon0
> [ 124.990411] protocol 0000 is buggy, dev nlmon0
> ...
>
> So just reset the network header before passing to the device; for
> packet sockets that just means nothing will change - mac and net
> offset hold the same value just as before.
>
> Reported-by: Marcel Holtmann <marcel@holtmann.org>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2014-08-07 23:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 20:22 [PATCH net] netlink: reset network header before passing to taps Daniel Borkmann
2014-08-07 23:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807.160617.1417231506028535686.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).