From: David Miller <davem@davemloft.net>
To: u.kleine-koenig@pengutronix.de
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: bcmgenet: fix reference counting for phy node
Date: Thu, 07 Aug 2014 16:07:08 -0700 (PDT) [thread overview]
Message-ID: <20140807.160708.1321297135015241670.davem@davemloft.net> (raw)
In-Reply-To: <1407444820-16250-1-git-send-email-u.kleine-koenig@pengutronix.de>
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Thu, 7 Aug 2014 22:53:40 +0200
> For the fixed phy setup make sure to not overwrite a valid value of
> phy_dn (that is holding a reference to a phy-handle) and also acquire a
> reference to the MAC node to consistently return with the phy_dn pointer
> holding a reference.
>
> Also add the corresponding of_node_put in the error path and the remove
> function.
>
> Fixes: 9abf0c2b717a ("net: bcmgenet: use the new fixed PHY helpers")
> Fixes: aa09677cba42 ("net: bcmgenet: add MDIO routines")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied.
prev parent reply other threads:[~2014-08-07 23:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 20:53 [PATCH] net: bcmgenet: fix reference counting for phy node Uwe Kleine-König
2014-08-07 23:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807.160708.1321297135015241670.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).