From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: vyasevic@redhat.com, netdev@vger.kernel.org, kaber@trash.net,
nsujir@broadcom.com, mchan@broadcom.com
Subject: Re: [PATCH net] net: Always untag vlan-tagged traffic on input.
Date: Fri, 08 Aug 2014 10:37:43 -0700 (PDT) [thread overview]
Message-ID: <20140808.103743.1027471237079294169.davem@davemloft.net> (raw)
In-Reply-To: <20140808152618.GC1878@nanopsycho.orion>
From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 8 Aug 2014 17:26:18 +0200
> Thu, Aug 07, 2014 at 04:55:34PM CEST, vyasevic@redhat.com wrote:
>>+struct sk_buff *skb_untag(struct sk_buff *skb)
>
> I would suggest to rename this to "skb_vlan_untag" to make this clear.
> Other than that, the patch looks good to me.
Agreed.
prev parent reply other threads:[~2014-08-08 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 14:55 [PATCH net] net: Always untag vlan-tagged traffic on input Vladislav Yasevich
2014-08-08 15:26 ` Jiri Pirko
2014-08-08 17:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140808.103743.1027471237079294169.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kaber@trash.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nsujir@broadcom.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).