From: David Miller <davem@davemloft.net>
To: vyasevic@redhat.com
Cc: netdev@vger.kernel.org, kaber@trash.net, nsujir@broadcom.com,
mchan@broadcom.com, jiri@resnulli.us
Subject: Re: [PATCH v2 net] net: Always untag vlan-tagged traffic on input.
Date: Mon, 11 Aug 2014 12:17:26 -0700 (PDT) [thread overview]
Message-ID: <20140811.121726.433178704630420349.davem@davemloft.net> (raw)
In-Reply-To: <1407523333-31455-1-git-send-email-vyasevic@redhat.com>
From: Vladislav Yasevich <vyasevic@redhat.com>
Date: Fri, 8 Aug 2014 14:42:13 -0400
> Currently the functionality to untag traffic on input resides
> as part of the vlan module and is build only when VLAN support
> is enabled in the kernel. When VLAN is disabled, the function
> vlan_untag() turns into a stub and doesn't really untag the
> packets. This seems to create an interesting interaction
> between VMs supporting checksum offloading and some network drivers.
...
> The patch attempt to fix this another way. It moves the vlan header
> stipping code out of the vlan module and always builds it into the
> kernel network core. This way, even if vlan is not supported on
> a virtualizatoin host, the virtual machines running on top of such
> host will still work with VLANs enabled.
>
> CC: Patrick McHardy <kaber@trash.net>
> CC: Nithin Nayak Sujir <nsujir@broadcom.com>
> CC: Michael Chan <mchan@broadcom.com>
> CC: Jiri Pirko <jiri@resnulli.us>
> Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com>
Applied and queued up for -stable, thanks Vlad.
next prev parent reply other threads:[~2014-08-11 19:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 18:42 [PATCH v2 net] net: Always untag vlan-tagged traffic on input Vladislav Yasevich
2014-08-09 6:44 ` Jiri Pirko
2014-08-11 19:17 ` David Miller [this message]
2014-09-29 12:44 ` Nicolas Dichtel
2014-09-29 13:05 ` Jiri Pirko
2014-09-29 13:46 ` Nicolas Dichtel
2014-09-29 13:54 ` Vlad Yasevich
2014-09-29 13:58 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811.121726.433178704630420349.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kaber@trash.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nsujir@broadcom.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).