From mboxrd@z Thu Jan 1 00:00:00 1970 From: Himangi Saraogi Subject: [PATCH] net/udp_offload: Drop unnecessary continue Date: Wed, 13 Aug 2014 14:46:05 +0530 Message-ID: <20140813091605.GA2947@himangi-Dell> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Julia Lawall To: "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Continue is not needed at the bottom of a loop. The Coccinelle semantic patch implementing this change is: @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- net/ipv4/udp_offload.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c index 59035bc..62d5b9b 100644 --- a/net/ipv4/udp_offload.c +++ b/net/ipv4/udp_offload.c @@ -269,10 +269,8 @@ unflush: continue; uh2 = (struct udphdr *)(p->data + off); - if ((*(u32 *)&uh->source != *(u32 *)&uh2->source)) { + if ((*(u32 *)&uh->source != *(u32 *)&uh2->source)) NAPI_GRO_CB(p)->same_flow = 0; - continue; - } } skb_gro_pull(skb, sizeof(struct udphdr)); /* pull encapsulating udp header */ -- 1.9.1