From: David Miller <davem@redhat.com>
To: chas@cmf.nrl.navy.mil
Cc: netdev@vger.kernel.org, linux-atm-general@lists.sourceforge.net
Subject: Re: [PATCH net-next] lec: Use rtnl lock/unlock when updating MTU
Date: Thu, 14 Aug 2014 14:37:06 -0700 (PDT) [thread overview]
Message-ID: <20140814.143706.1833450188258591738.davem@redhat.com> (raw)
In-Reply-To: <201408141319.s7EDJl9l031767@thirdoffive.cmf.nrl.navy.mil>
From: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Date: Thu, 14 Aug 2014 09:19:47 -0400
> The LECS response contains the MTU that should be used. Correctly
> synchronize with other layers when updating.
>
> Signed-off-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
I don't think you can sleep from this function, which rtnl_lock() may
require. Look elsewhere in this routine, it's doing GFP_ATOMIC
allocations even.
next prev parent reply other threads:[~2014-08-14 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 13:19 [PATCH net-next] lec: Use rtnl lock/unlock when updating MTU Chas Williams - CONTRACTOR
2014-08-14 21:37 ` David Miller [this message]
2014-08-15 0:56 ` Chas Williams (CONTRACTOR)
2014-08-21 23:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140814.143706.1833450188258591738.davem@redhat.com \
--to=davem@redhat.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox