From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: smsc911x_suspend crash (was: Re: [PATCH] ARM: shmobile: r8a7778: Add missing call to shmobile_init_late()) Date: Fri, 15 Aug 2014 06:18:17 +0900 Message-ID: <20140814211817.GD2029@verge.net.au> References: <53ECEB7E.9040300@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Geert Uytterhoeven , Geert Uytterhoeven , Kuninori Morimoto , Magnus Damm , Linux-sh list , Kevin Hilman , "netdev@vger.kernel.org" To: Florian Fainelli Return-path: Content-Disposition: inline In-Reply-To: <53ECEB7E.9040300@gmail.com> Sender: linux-sh-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, Aug 14, 2014 at 10:01:50AM -0700, Florian Fainelli wrote: > Hi Geert, > > On 08/14/2014 01:52 AM, Geert Uytterhoeven wrote: > > Hi Simon, > > > > (taking this to netdev for the crash in smsc911x_suspend()) > > > > On Thu, Aug 14, 2014 at 8:16 AM, Simon Horman wrote: > >> while this may be part of the puzzle my light testing shows > >> that suspend-to-ram does not appear to work with this patch applied. > > > > Thanks for testing! > > Sounds like you are another victim of: > a71e3c37960ce5f9 ("net: phy: Set the driver when registering an MDIO bus > device") > > which got reverted just recently: > ce7991e8198b80eb6b4441b6f6114bea4a665d66 ("Revert "net: phy: Set the > driver when registering an MDIO bus device""). Thanks, that did the trick. Geert, I'll queue up your patch for the r8a7778.