From: Benjamin Poirier <benjamin.poirier@gmail.com>
To: Prashant Sreedharan <prashant@broadcom.com>,
Michael Chan <mchan@broadcom.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] tg3: Fix tx_pending checks for tg3_tso_bug
Date: Tue, 19 Aug 2014 13:56:27 -0700 [thread overview]
Message-ID: <20140819205627.GA20702@f1.synalogic.ca> (raw)
In-Reply-To: <1408474371-19509-2-git-send-email-bpoirier@suse.de>
On 2014/08/19 11:52, Benjamin Poirier wrote:
> + trace_printk("stopping queue, %d <= %d\n",
> + tg3_tx_avail(tnapi), skb_shinfo(skb)->gso_segs);
> netif_tx_stop_queue(txq);
> + trace_printk("stopped queue\n");
err, I'll resubmit without the trace_printk. Please review for other
issues nevertheless.
next prev parent reply other threads:[~2014-08-19 20:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 18:52 [PATCH 1/3] tg3: Limit minimum tx queue wakeup threshold Benjamin Poirier
2014-08-19 18:52 ` [PATCH 2/3] tg3: Fix tx_pending checks for tg3_tso_bug Benjamin Poirier
2014-08-19 20:56 ` Benjamin Poirier [this message]
2014-08-19 23:10 ` Michael Chan
2014-08-21 1:23 ` Benjamin Poirier
2014-08-21 9:51 ` Michael Chan
2014-08-21 21:59 ` Benjamin Poirier
2014-08-22 4:25 ` David Miller
2014-08-19 18:52 ` [PATCH 3/3] tg3: Fix tx_pending check for MAX_SKB_FRAGS Benjamin Poirier
2014-08-19 22:00 ` [PATCH 1/3] tg3: Limit minimum tx queue wakeup threshold Michael Chan
2014-08-21 22:04 ` Benjamin Poirier
2014-08-21 22:32 ` Michael Chan
2014-08-21 23:06 ` Benjamin Poirier
2014-08-21 23:26 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819205627.GA20702@f1.synalogic.ca \
--to=benjamin.poirier@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).