From: Stephen Hemminger <stephen@networkplumber.org>
To: Andy Gospodarek <gospo@cumulusnetworks.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, davem@davemloft.net,
j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net,
nikolay@redhat.com, dingtianhong@huawei.com,
sfeldma@cumulusnetworks.com
Subject: Re: [patch net-next] bonding: create netlink event when bonding option is changed
Date: Wed, 20 Aug 2014 10:49:01 -0700 [thread overview]
Message-ID: <20140820104901.2bbf9965@uryu.home.lan> (raw)
In-Reply-To: <20140820140051.GC1954@gospo.home.greyhouse.net>
On Wed, 20 Aug 2014 10:00:51 -0400
Andy Gospodarek <gospo@cumulusnetworks.com> wrote:
> > >
> > >My question was: Is there a need for 2 netlink messages to indicate
> > >that a bonding configuration change was needed when the config came over
> > >netlink. I did not see the need for 2 netlink messages in this case and
> > >was asking for clarification from you.
> >
> > Imagine 2 applications. One is just monitoring netlink events ("ip
> > mon"), the second is setting up bond via netlink. Now, the second sends
> > a message to kernel, that is unicast to kernel. The first application
> > does not see that message. Therefore there is need to generate the event
> > message in kernel and send it back to userspace via multicast.
> > That message the first application will see. And that is exactly what
> > my patch is doing.
>
> Agreed. Thanks for having the discussion on this.
>
> Acked-by: Andy Gospodarek <gospo@cumulusnetworks.com>
Quagga uses socket filter to solve this problem.
The application filters out it's own route change events.
next prev parent reply other threads:[~2014-08-20 17:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 14:02 [patch net-next] bonding: create netlink event when bonding option is changed Jiri Pirko
2014-08-19 20:34 ` Andy Gospodarek
2014-08-19 20:37 ` Jiri Pirko
2014-08-19 20:46 ` Andy Gospodarek
2014-08-20 6:44 ` Jiri Pirko
2014-08-20 11:11 ` Veaceslav Falico
2014-08-20 14:00 ` Andy Gospodarek
2014-08-20 17:49 ` Stephen Hemminger [this message]
2014-08-20 12:18 ` Neil Horman
2014-08-20 12:49 ` Jiri Pirko
2014-08-22 19:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140820104901.2bbf9965@uryu.home.lan \
--to=stephen@networkplumber.org \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=gospo@cumulusnetworks.com \
--cc=j.vosburgh@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
--cc=sfeldma@cumulusnetworks.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).