From: David Miller <davem@davemloft.net>
To: anish@chelsio.com
Cc: netdev@vger.kernel.org, hariprasad@chelsio.com,
leedom@chelsio.com, svemuri@chelsio.com, nhorman@redhat.com
Subject: Re: [PATCH net v2] cxgb4: Fix race condition in cleanup
Date: Thu, 21 Aug 2014 21:45:47 -0700 (PDT) [thread overview]
Message-ID: <20140821.214547.1331125403351758274.davem@davemloft.net> (raw)
In-Reply-To: <1408567446-6598-1-git-send-email-anish@chelsio.com>
From: Anish Bhatt <anish@chelsio.com>
Date: Wed, 20 Aug 2014 13:44:06 -0700
> There is a possible race condition when we unregister the PCI Driver and then
> flush/destroy the global "workq". This could lead to situations where there
> are tasks on the Work Queue with references to now deleted adapter data
> structures. Instead, have per-adapter Work Queues which were instantiated and
> torn down in init_one() and remove_one(), respectively.
>
> v2: Remove unnecessary call to flush_workqueue() before destroy_workqueue()
>
> Signed-off-by: Anish Bhatt <anish@chelsio.com>
> Signed-off-by: Casey Leedom <leedom@chelsio.com>
Applied thanks.
prev parent reply other threads:[~2014-08-22 4:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 20:44 [PATCH net v2] cxgb4: Fix race condition in cleanup Anish Bhatt
2014-08-21 11:54 ` Neil Horman
2014-08-22 4:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821.214547.1331125403351758274.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anish@chelsio.com \
--cc=hariprasad@chelsio.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=svemuri@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).