From: Stephen Hemminger <stephen@networkplumber.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: netdev@vger.kernel.org
Subject: Re: TCP output handling bug ?
Date: Thu, 21 Aug 2014 17:24:45 -0700 [thread overview]
Message-ID: <20140821172445.7c1ba422@uryu.home.lan> (raw)
In-Reply-To: <20140821190208.208e0de1@www.etchedpixels.co.uk>
On Thu, 21 Aug 2014 19:02:08 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
> tcp_send_syn_data:
>
> TCP_SKB_CB(data)->tcp_flags &= ~TCPHDR_SYN;
> TCP_SKB_CB(data)->tcp_flags = (TCPHDR_ACK|TCPHDR_PSH);
>
> the reporter has a point 8)
>
>
> https://bugzilla.kernel.org/show_bug.cgi?id=82101
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
I wonder if covertity or smatch could be smart enough to catch this kind of bug?
next prev parent reply other threads:[~2014-08-22 0:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 18:02 TCP output handling bug ? Alan Cox
2014-08-22 0:24 ` Stephen Hemminger [this message]
2014-08-22 2:13 ` Dave Jones
2014-08-22 13:56 ` Eric Dumazet
2014-08-22 17:41 ` David Miller
2014-08-22 18:18 ` Yuchung Cheng
2014-08-22 18:30 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140821172445.7c1ba422@uryu.home.lan \
--to=stephen@networkplumber.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).