From: David Miller <davem@davemloft.net>
To: bebl@mageta.org
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, hannes@redhat.com
Subject: Re: [PATCH v2] net: ipv6: fib: don't sleep inside atomic lock
Date: Fri, 22 Aug 2014 10:55:37 -0700 (PDT) [thread overview]
Message-ID: <20140822.105537.779696105209269317.davem@davemloft.net> (raw)
In-Reply-To: <1408642668-5808-1-git-send-email-bebl@mageta.org>
From: Benjamin Block <bebl@mageta.org>
Date: Thu, 21 Aug 2014 19:37:48 +0200
> The function fib6_commit_metrics() allocates a piece of memory in mode
> GFP_KERNEL while holding an atomic lock from higher up in the stack, in
> the function __ip6_ins_rt(). This produces the following BUG:
...
> Fixing this by replacing the mode GFP_KERNEL with GFP_ATOMIC.
>
> Signed-off-by: Benjamin Block <bebl@mageta.org>
Applied, thanks.
prev parent reply other threads:[~2014-08-22 17:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 16:16 [PATCH] net: ipv6: fib: don't sleep inside atomic lock Benjamin Block
2014-08-21 12:54 ` Hannes Frederic Sowa
2014-08-21 14:31 ` Benjamin Block
2014-08-21 17:37 ` [PATCH v2] " Benjamin Block
2014-08-21 21:57 ` David Rientjes
2014-08-21 22:12 ` Hannes Frederic Sowa
2014-08-22 17:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822.105537.779696105209269317.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bebl@mageta.org \
--cc=hannes@redhat.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).