* [PATCH] isdn/bas_gigaset: use USB API functions rather than constants
@ 2014-08-17 0:31 Himangi Saraogi
2014-08-17 11:45 ` Tilman Schmidt
2014-08-22 19:27 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Himangi Saraogi @ 2014-08-17 0:31 UTC (permalink / raw)
To: Hansjoerg Lipp, Tilman Schmidt, Karsten Keil, gigaset307x-common,
netdev, linux-kernel
Cc: Julia Lawall
This patch introduces the use of the function usb_endpoint_num.
The Coccinelle semantic patch that makes these changes is as follows:
@@ struct usb_endpoint_descriptor *epd; @@
- (epd->bEndpointAddress & \(USB_ENDPOINT_NUMBER_MASK\|0x0f\))
+ usb_endpoint_num(epd)
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
drivers/isdn/gigaset/bas-gigaset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/gigaset/bas-gigaset.c b/drivers/isdn/gigaset/bas-gigaset.c
index b7ae0a0..aecec6d 100644
--- a/drivers/isdn/gigaset/bas-gigaset.c
+++ b/drivers/isdn/gigaset/bas-gigaset.c
@@ -2365,7 +2365,7 @@ static int gigaset_probe(struct usb_interface *interface,
endpoint = &hostif->endpoint[0].desc;
usb_fill_int_urb(ucs->urb_int_in, udev,
usb_rcvintpipe(udev,
- (endpoint->bEndpointAddress) & 0x0f),
+ usb_endpoint_num(endpoint)),
ucs->int_in_buf, IP_MSGSIZE, read_int_callback, cs,
endpoint->bInterval);
rc = usb_submit_urb(ucs->urb_int_in, GFP_KERNEL);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] isdn/bas_gigaset: use USB API functions rather than constants
2014-08-17 0:31 [PATCH] isdn/bas_gigaset: use USB API functions rather than constants Himangi Saraogi
@ 2014-08-17 11:45 ` Tilman Schmidt
2014-08-22 19:27 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Tilman Schmidt @ 2014-08-17 11:45 UTC (permalink / raw)
To: Himangi Saraogi, Hansjoerg Lipp, Karsten Keil, gigaset307x-common,
netdev, linux-kernel
Cc: Julia Lawall
Am 17.08.2014 um 02:31 schrieb Himangi Saraogi:
> This patch introduces the use of the function usb_endpoint_num.
>
> The Coccinelle semantic patch that makes these changes is as follows:
>
> @@ struct usb_endpoint_descriptor *epd; @@
>
> - (epd->bEndpointAddress & \(USB_ENDPOINT_NUMBER_MASK\|0x0f\))
> + usb_endpoint_num(epd)
>
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Acked-by: Tilman Schmidt <tilman@imap.cc>
Thanks,
Tilman
> ---
> drivers/isdn/gigaset/bas-gigaset.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/isdn/gigaset/bas-gigaset.c b/drivers/isdn/gigaset/bas-gigaset.c
> index b7ae0a0..aecec6d 100644
> --- a/drivers/isdn/gigaset/bas-gigaset.c
> +++ b/drivers/isdn/gigaset/bas-gigaset.c
> @@ -2365,7 +2365,7 @@ static int gigaset_probe(struct usb_interface *interface,
> endpoint = &hostif->endpoint[0].desc;
> usb_fill_int_urb(ucs->urb_int_in, udev,
> usb_rcvintpipe(udev,
> - (endpoint->bEndpointAddress) & 0x0f),
> + usb_endpoint_num(endpoint)),
> ucs->int_in_buf, IP_MSGSIZE, read_int_callback, cs,
> endpoint->bInterval);
> rc = usb_submit_urb(ucs->urb_int_in, GFP_KERNEL);
>
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] isdn/bas_gigaset: use USB API functions rather than constants
2014-08-17 0:31 [PATCH] isdn/bas_gigaset: use USB API functions rather than constants Himangi Saraogi
2014-08-17 11:45 ` Tilman Schmidt
@ 2014-08-22 19:27 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-08-22 19:27 UTC (permalink / raw)
To: himangi774
Cc: hjlipp, tilman, isdn, gigaset307x-common, netdev, linux-kernel,
julia.lawall
From: Himangi Saraogi <himangi774@gmail.com>
Date: Sun, 17 Aug 2014 06:01:20 +0530
> This patch introduces the use of the function usb_endpoint_num.
>
> The Coccinelle semantic patch that makes these changes is as follows:
>
> @@ struct usb_endpoint_descriptor *epd; @@
>
> - (epd->bEndpointAddress & \(USB_ENDPOINT_NUMBER_MASK\|0x0f\))
> + usb_endpoint_num(epd)
>
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-22 19:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-17 0:31 [PATCH] isdn/bas_gigaset: use USB API functions rather than constants Himangi Saraogi
2014-08-17 11:45 ` Tilman Schmidt
2014-08-22 19:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).