From: David Miller <davem@davemloft.net>
To: hayeswang@realtek.com
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next 0/4] r8152: firmware support
Date: Fri, 22 Aug 2014 19:41:11 -0700 (PDT) [thread overview]
Message-ID: <20140822.194111.760144805197214266.davem@davemloft.net> (raw)
In-Reply-To: <1394712342-15778-16-Taiwan-albertk@realtek.com>
From: Hayes Wang <hayeswang@realtek.com>
Date: Wed, 20 Aug 2014 16:58:35 +0800
> Parsing, checking, and writing the firmware.
You haven't told us why you need to do this.
These are just programming registers in the chip, and I see no reason
to not keep these in the driver with real code.
I'm not applying this series, you haven't explained what is happening
here and the reason for doing so. Ironically, that's exactly what you
are supposed to provide in this 0/4 header email.
next prev parent reply other threads:[~2014-08-23 2:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 8:58 [PATCH net-next 0/4] r8152: firmware support Hayes Wang
2014-08-20 8:58 ` [PATCH net-next 1/4] r8152: check code with checkpatch.pl Hayes Wang
[not found] ` <1394712342-15778-16-Taiwan-albertk-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org>
2014-08-20 8:58 ` [PATCH net-next 2/4] r8152: replace strncpy with strlcpy Hayes Wang
2014-08-20 8:58 ` [PATCH net-next 3/4] r8152: remove clear_bp function Hayes Wang
2014-08-20 12:00 ` Sergei Shtylyov
[not found] ` <201408210131.s7L1VuAJ031162@rtits1.realtek.com>
2014-08-21 2:12 ` Hayes Wang
[not found] ` <0835B3720019904CB8F7AA43166CEEB2515BB5-JIZ+AM9kKNzuvTFwvkocLypo8c9IxeqyAjHCUHv49ws@public.gmane.org>
2014-08-21 17:29 ` Sergei Shtylyov
2014-08-22 2:38 ` Hayes Wang
2014-08-20 8:58 ` [PATCH net-next 4/4] r8152: support firmware files Hayes Wang
2014-08-20 12:01 ` Daniele Forsi
2014-08-20 12:35 ` Hayes Wang
[not found] ` <0835B3720019904CB8F7AA43166CEEB251585A-JIZ+AM9kKNzuvTFwvkocLypo8c9IxeqyAjHCUHv49ws@public.gmane.org>
2014-08-20 13:32 ` Daniele Forsi
2014-08-24 21:20 ` Francois Romieu
2014-08-25 3:23 ` Hayes Wang
2014-08-23 2:41 ` David Miller [this message]
[not found] ` <20140822.194111.760144805197214266.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-08-25 3:43 ` [PATCH net-next 0/4] r8152: firmware support Hayes Wang
2014-08-25 4:26 ` David Miller
[not found] ` <20140824.212614.2300459100680592586.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-08-25 6:43 ` Hayes Wang
2014-08-25 7:00 ` David Miller
2014-08-25 7:53 ` [PATCH net-next] r8152: check code with checkpatch.pl Hayes Wang
2014-08-25 19:58 ` David Miller
2014-08-26 2:08 ` [PATCH net-next] r8152: replace strncpy with strlcpy Hayes Wang
2014-08-27 23:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140822.194111.760144805197214266.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).