From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next RFC 03/12] net: introduce generic switch devices support Date: Sat, 23 Aug 2014 11:17:26 +0200 Message-ID: <20140823091726.GB1854@nanopsycho.orion> References: <1408637945-10390-1-git-send-email-jiri@resnulli.us> <1408637945-10390-4-git-send-email-jiri@resnulli.us> <53F73A9C.4000209@mojatatu.com> <20140822125655.GB1916@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Sergey Ryazanov , "jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , John Fastabend , Neil Jerram , Eric Dumazet , Andy Gospodarek , dev , Felix Fietkau , ronye-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, Jeff Kirsher , ogerlitz , Ben Hutchings , Lennert Buytenhek , Roopa Prabhu , Jamal Hadi Salim , Aviad Raveh , Nicolas Dichtel , vyasevic , Neil Horman , netdev , Stephen Hemminger , dborkman , "Eric W. Biederman" , David Mi To: Florian Fainelli Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Sender: "dev" List-Id: netdev.vger.kernel.org Sat, Aug 23, 2014 at 03:02:10AM CEST, f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: >2014-08-22 5:56 GMT-07:00 Jiri Pirko : >> Fri, Aug 22, 2014 at 02:42:04PM CEST, jhs-jkUAjuhPggJWk0Htik3J/w@public.gmane.org wrote: >>>On 08/21/14 13:05, Florian Fainelli wrote: >>>>2014-08-21 9:18 GMT-07:00 Jiri Pirko : >>>>>The goal of this is to provide a possibility to suport various switch >>>>>chips. Drivers should implement relevant ndos to do so. Now there is a >>>>>couple of ndos defines: >>>>>- for getting physical switch id is in place. >>>>>- for work with flows. >>>>> >>>>>Note that user can use random port netdevice to access the switch. >>>> >>>>I read through this patch set, and I still think that DSA is the >>>>generic switch infrastructure we already have because it does provide >>>>the following: >>>> >>>>- taking a generic platform data structure (C struct or Device Tree), >>>>validate, parse it and map it to internal kernel structures >>>>- instantiate per-port network devices based on the configuration data provided >>>>- delegate netdev_ops to the switch driver and/or the CPU NIC when relevant >>>>- provide support for hooking RX and TX traffic coming from the CPU NIC >>>> >>>>I would rather we build on the existing DSA infrastructure and add the >>>>flow-related netdev_ops rather than having the two remain in >>>>disconnect while flow-oriented switches driver get progressively >>>>added. I guess I should take a closer look at the rocker driver to see >>>>how hard would that be for you. >>>> >>>>What do you think? >>> >>> >>>I thought we had concluded that DSA was a good path forward? Or maybe at >>>this stage we need to have several alternative approaches >>>and we eventually converge? >> >> That is true. I'm still unsure how to fit this on to DSA or how to change DSA >> the way this fits. This is my quest now. Will report back in a week or so. > >I don't want to hold off this patch series, so let's proceed with your >submission, since I believe John Fastabend would also directly benefit >from this. > >In the meantime, I will keep working on DSA, and prototype changes >with the rocker driver. > >Once we are confident we have bridged the gap, we can unify things. >How does that sound? Sounds good.