Re: [PATCH net-next] net: Functions to report space available in device TX queues

[David Miller <davem@davemloft.net>]

From: Tom Herbert <therbert@google.com>
Date: Sun, 24 Aug 2014 13:19:47 -0700 (PDT)

> +/**
> + *	netdev_avail_queue - report how much space is availble for xmit
> + *	@dev: network device
> + *
> + *	Report the amount of space available in the TX queue in terms of
> + *	number of bytes. This returns the number of bytes avaiable per
> + *	DQL. This function may be called without taking the txlock on
> + *	the device, however in that case the result should be taken as
> + *	a (strong) hint.
> + */
> +static inline int netdev_avail_queue(struct net_device *dev_queue)
> +{
> +	return netdev_tx_avail_queue(netdev_get_tx_queue(dev_queue, 0));
> +}
> +

This doesn't make any sense, you're only providing queue zero's
information.

You're passing in a net_device, calling it a "dev_queue" in the
variable name, the exlicitly using queue zero of that device in the
netdev_get_tx_queue() call.

Pretty confusing if you ask me :)