From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, stephen@networkplumber.org,
cwang@twopensource.com, pshelar@nicira.com,
nicolas.dichtel@6wind.com, therbert@google.com,
dborkman@redhat.com, edumazet@google.com
Subject: Re: [patch net-next 1/3] net: propagate sock pointer through netfilter hooks
Date: Mon, 25 Aug 2014 12:52:01 -0700 (PDT) [thread overview]
Message-ID: <20140825.125201.1587978115657653201.davem@davemloft.net> (raw)
In-Reply-To: <20140825192926.GC1871@nanopsycho.lan>
From: Jiri Pirko <jiri@resnulli.us>
Date: Mon, 25 Aug 2014 21:29:26 +0200
> Mon, Aug 25, 2014 at 08:51:03PM CEST, davem@davemloft.net wrote:
>>From: Jiri Pirko <jiri@resnulli.us>
>>Date: Mon, 25 Aug 2014 16:05:10 +0200
>>
>>> Dave, I see that the patchset is in state "Changes requested". I do not
>>> think I understand what is needed to be done at this point. Would you
>>> please tell me? Thanks.
>>
>>I said there is too much churn so I want an alternative approach
>>considered.
>>
>>Also want you to fix the ipv6 fragmentation error too.
>
>
> Hmm. When skb->x adding is no-go and propagating sk through nf hooks is
> no go, I really do not see the way to fix this... I might be missing
> something though...
Change the order of operations so that sk can be evaluated and tested
earlier in the code paths, before the NF_HOOK executes.
Or only store the boolean result of the test in the sk_buff.
Please, try to be creative, do not just see black and white. :-)
prev parent reply other threads:[~2014-08-25 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 18:32 [patch net-next 1/3] net: propagate sock pointer through netfilter hooks Jiri Pirko
2014-08-15 18:32 ` [patch net-next 2/3] vxlan: propagate sock pointer to ip6tunnel_xmit path Jiri Pirko
2014-08-15 18:32 ` [patch net-next 3/3] ipv6: check propagates sk in sk_mc_loop instead of skb->sk Jiri Pirko
2014-08-22 0:33 ` [patch net-next 1/3] net: propagate sock pointer through netfilter hooks David Miller
2014-08-22 5:56 ` Jiri Pirko
2014-08-25 14:05 ` Jiri Pirko
2014-08-25 18:51 ` David Miller
2014-08-25 19:29 ` Jiri Pirko
2014-08-25 19:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825.125201.1587978115657653201.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cwang@twopensource.com \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=jmorris@namei.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pshelar@nicira.com \
--cc=stephen@networkplumber.org \
--cc=therbert@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).