From: David Miller <davem@davemloft.net>
To: alexander.h.duyck@intel.com
Cc: eric.dumazet@gmail.com, amirv@mellanox.com,
netdev@vger.kernel.org, ogerlitz@mellanox.com,
yevgenyp@mellanox.com, idos@mellanox.com, therbert@google.com
Subject: Re: [PATCH net-next 1/2] net: Header length compution function
Date: Mon, 25 Aug 2014 15:32:32 -0700 (PDT) [thread overview]
Message-ID: <20140825.153232.123310243841432720.davem@davemloft.net> (raw)
In-Reply-To: <53FBB702.8080905@intel.com>
From: Alexander Duyck <alexander.h.duyck@intel.com>
Date: Mon, 25 Aug 2014 15:21:54 -0700
> On 08/23/2014 12:19 PM, David Miller wrote:
>> From: Alexander Duyck <alexander.h.duyck@intel.com>
>> Date: Thu, 31 Jul 2014 08:34:22 -0700
>>
>>> On 07/30/2014 06:39 PM, David Miller wrote:
>>>> I don't think my proposed patch is a bad trade off. Where we have the
>>>> __skb_header_pointer() thing that takes preloaded pointers and header
>>>> length values. It adds only one test which frankly should never
>>>> trigger and can be moved down into skb_copy_bits() or similar.
>>>
>>> This works for me. Once it is in I can see about pushing a patch to add
>>> some FCoE support and work on moving over igb and ixgbe.
>>
>> You should be able to do this against net-next now, just FYI.
>>
>
> Actually I was just looking at the code. It looks like commit
> 19469a873bafd4e65daef3597db2bd724c1b03c9 "flow_dissector: Use IPv6 flow
> label in flow_dissector" is likely breaking things in terms of trying to
> use this function to get the header length since the code now returns
> early if an IPv6 flow label is present.
Feel free to insert a facility to disable that logic.
next prev parent reply other threads:[~2014-08-25 22:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 10:14 [PATCH net-next 0/2] Helper to find length of headers in an ethernet frame Amir Vadai
2014-07-28 10:14 ` [PATCH net-next 1/2] net: Header length compution function Amir Vadai
2014-07-30 4:58 ` David Miller
2014-07-30 7:00 ` Eric Dumazet
2014-07-30 14:26 ` Alexander Duyck
2014-07-31 1:39 ` David Miller
2014-07-31 15:34 ` Alexander Duyck
2014-08-23 19:19 ` David Miller
2014-08-25 22:21 ` Alexander Duyck
2014-08-25 22:32 ` David Miller [this message]
2014-07-31 1:34 ` David Miller
2014-07-28 10:14 ` [PATCH net-next 2/2] net/mlx4_en: Copy exact header to SKB linear part Amir Vadai
2014-07-28 10:56 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825.153232.123310243841432720.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=amirv@mellanox.com \
--cc=eric.dumazet@gmail.com \
--cc=idos@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=therbert@google.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).