Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jonas.jensen@gmail.com
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, f.fainelli@gmail.com,
	eric.dumazet@gmail.com, mirqus@gmail.com
Subject: Re: [PATCH v6 4/4] net: moxa: continue loop on skb allocation failure
Date: Mon, 25 Aug 2014 17:26:15 -0700 (PDT)	[thread overview]
Message-ID: <20140825.172615.1598002278628891621.davem@davemloft.net> (raw)
In-Reply-To: <1408976560-15694-1-git-send-email-jonas.jensen@gmail.com>

From: Jonas Jensen <jonas.jensen@gmail.com>
Date: Mon, 25 Aug 2014 16:22:40 +0200

> If netdev_alloc_skb_ip_align() fails, subsequent code will
> try to dereference an invalid pointer.
> 
> Continue to next descriptor on error.
> 
> While we're at it,
> 
> 1. eliminate the chance of an endless loop, replace the main
>    loop with while(rx < budget)
> 
> 2. use napi_complete() and remove the explicit napi_gro_flush()
> 
> Signed-off-by: Jonas Jensen <jonas.jensen@gmail.com>

Applied.

      reply	other threads:[~2014-08-26  0:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25 14:22 [PATCH v6 4/4] net: moxa: continue loop on skb allocation failure Jonas Jensen
2014-08-26  0:26 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140825.172615.1598002278628891621.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=jonas.jensen@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mirqus@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox