From: David Miller <davem@davemloft.net>
To: wei.liu2@citrix.com
Cc: xen-devel@lists.xen.org, netdev@vger.kernel.org,
talex5@gmail.com, ian.campbell@citrix.com
Subject: Re: [PATCH net] xen-netback: move netif_napi_add before binding interrupt
Date: Mon, 25 Aug 2014 17:32:20 -0700 (PDT) [thread overview]
Message-ID: <20140825.173220.130220460265473405.davem@davemloft.net> (raw)
In-Reply-To: <1408981440-19255-1-git-send-email-wei.liu2@citrix.com>
From: Wei Liu <wei.liu2@citrix.com>
Date: Mon, 25 Aug 2014 16:44:00 +0100
> Interrupt is enabled when bind_interdomain_evtchn_to_irqhandler returns.
> If there's interrupt pending interrupt handler is invoked.
>
> NAPI needs to be initialised before binding interrupt otherwise the
> interrupt handler will try to scheduling a NAPI instance that is not
> initialised yet, resulting in kernel OOPS.
>
> This fixes a regression introduced in ea2c5e13 ("xen-netback: move NAPI
> add/remove calls").
>
> Ideally function calls to create kthreads should also be moved before
> binding but I intent to fix this regression with minimal changes and
> refactor the code with another patch.
>
> Reported-by: Thomas Leonard <talex5@gmail.com>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2014-08-26 0:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 15:44 [PATCH net] xen-netback: move netif_napi_add before binding interrupt Wei Liu
2014-08-26 0:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825.173220.130220460265473405.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=talex5@gmail.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).