netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: therbert@google.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net: Functions to report space available in device TX queues
Date: Mon, 25 Aug 2014 17:33:25 -0700 (PDT)	[thread overview]
Message-ID: <20140825.173325.723351409734098574.davem@davemloft.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1408250823440.31745@tomh.mtv.corp.google.com>

From: Tom Herbert <therbert@google.com>
Date: Mon, 25 Aug 2014 08:27:56 -0700 (PDT)

> This patch adds netdev_tx_avail_queue and netdev_avail_queue which are
> used to report number of bytes available in transmit queues per BQL. The
> functions call dql_avail which returns BQL limit minus number of
> inflight bytes. These functions can be called without txlock, for
> instance to ascertain how much data should be dequeued from a qdisc in
> a batch. When called without the tx_lock, the result is technically a
> hint, subsequently when the tx_lock is done for a transmit it is
> possible the availability has changed (for example a transmit
> completion may have freed up more space in the queue or changed the
> limit).
> 
> Signed-off-by: Tom Herbert <therbert@google.com>

Ok this looks fine, but could you please resubmit this alongside
the first use case?

Thanks.

  reply	other threads:[~2014-08-26  0:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25 15:27 [PATCH v2 net-next] net: Functions to report space available in device TX queues Tom Herbert
2014-08-26  0:33 ` David Miller [this message]
2014-08-26 15:44   ` Tom Herbert
2014-09-03 13:20 ` Jesper Dangaard Brouer
2014-09-03 13:41   ` Eric Dumazet
2014-09-03 13:49     ` Jesper Dangaard Brouer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140825.173325.723351409734098574.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).